[GitHub] [tinkerpop] FlorianHockmann commented on a change in pull request #1536: TINKERPOP-2639 Removed Gryo MessageSerializers

[GitBox <gi...@apache.org>]

FlorianHockmann commented on a change in pull request #1536:
URL: https://github.com/apache/tinkerpop/pull/1536#discussion_r778742241



##########
File path: docs/src/reference/intro.asciidoc
##########
@@ -434,13 +434,9 @@ touch upon important concepts to focus on here.
 
 The first of these points is serialization. When Gremlin Server receives a request, the results must be serialized to
 the form requested by the client and then the client deserializes those into objects native to the language. TinkerPop
-has three such formats that it uses with link:https://tinkerpop.apache.org/docs/x.y.z/dev/io/#graphbinary[GraphBinary],
-link:https://tinkerpop.apache.org/docs/x.y.z/dev/io/#gryo[Gryo] and
-link:https://tinkerpop.apache.org/docs/x.y.z/dev/io/#graphson[GraphSON]. Among these serialization formats, users
-should prefer GraphBinary as it combines the best features of both GraphSON and Gryo and it provides the most even
-user experience across different programming languages. There are areas however where this is not quite true, as
-Gremlin Language Variants don't have full GTMs present and therefore don't have the complete means to accomplish what
-a pure JVM solution would.
+has two such formats that it uses with link:https://tinkerpop.apache.org/docs/x.y.z/dev/io/#graphbinary[GraphBinary],

Review comment:
       (nitpick) with GraphBinary _and_ GraphSON.

##########
File path: docs/src/dev/io/gryo.asciidoc
##########
@@ -160,6 +160,8 @@ As of TinkerPop 3.3.0, there is now a new version of Gryo in 3.0 that is only pa
 to use 3.0 serializers with 1.0 serializers will likely lead to failure. For best results, users should always
 utilize the same version of TinkerPop on the client as on the server.
 
+IMPORTANT: As of 3.6.0, Gryo `MessageSerializer` implementations have been removed from the codebase.

Review comment:
       Shouldn't we also at least remove this sentence from line 127:
   
   > This characteristic makes it ideal for use in Gremlin Server, which is designed to return arbitrary results of varying types
   
   as Gryo can now only be used a file I/O format?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org