You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/14 09:53:03 UTC

[GitHub] marcoabreu commented on a change in pull request #12792: Fix broken amalgamation

marcoabreu commented on a change in pull request #12792: Fix broken amalgamation
URL: https://github.com/apache/incubator-mxnet/pull/12792#discussion_r224986593
 
 

 ##########
 File path: amalgamation/amalgamation.py
 ##########
 @@ -143,7 +143,12 @@ def expand(x, pending, stage):
                 continue
             path = m.groups()[0]
             h = path.strip('./') if "../3rdparty/" not in path else path
-            source = find_source(h, x, stage)
+            if h.endswith('complex.h') and x.endswith('openblas_config.h'):
 
 Review comment:
   Could you add a comment explaining the special case? Also, is there maybe a nicer way to deal with this ambiguity - e.g. making the names (complex.h) more unique in the output to avoid a name clash?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services