You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Thomas D'Silva (JIRA)" <ji...@apache.org> on 2018/07/12 01:00:00 UTC

[jira] [Commented] (PHOENIX-4790) Simplify check for client side delete

    [ https://issues.apache.org/jira/browse/PHOENIX-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540953#comment-16540953 ] 

Thomas D'Silva commented on PHOENIX-4790:
-----------------------------------------

[~jamestaylor]

I think this patch is causing tests to fail : [BinaryRowKeyIT|eclipse-javadoc:%E2%98%82=phoenix-core/src%5C/it%5C/java%3Corg.apache.phoenix.end2end%7BBinaryRowKeyIT.java%E2%98%83BinaryRowKeyIT].testInsertPaddedBinaryValue() and [ArithmeticQueryIT|eclipse-javadoc:%E2%98%82=phoenix-core/src%5C/it%5C/java%3Corg.apache.phoenix.end2end%7BArithmeticQueryIT.java%E2%98%83ArithmeticQueryIT].testRandomFunction()

> Simplify check for client side delete
> -------------------------------------
>
>                 Key: PHOENIX-4790
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4790
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Minor
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4790.patch
>
>
> We don't need to check every query plan for the existence of a where clause to determine if we can do a client-side delete. Instead, we can simply check if any non PK columns are projected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)