答复: about pull 503

["Ma, Sheng-Chen (Aven)" <sh...@esgyn.cn>]

hi Steve:
I think u are right . I will do some change which will not rely on install_feature. Then I will have this discussion on dev list.

Thanks
Aven


发件人: Steve Varnau [mailto:steve.varnau@esgyn.com]
发送时间: 2016年6月3日 6:40
收件人: Ma, Sheng-Chen (Aven) <sh...@esgyn.cn>
抄送: Amanda Moran <am...@esgyn.com>
主题: RE: about pull 503

Hi Aven,

I think it would be really good to have this discussion on the dev list or on github.  Others may also be confused by my remarks or may have different opinions than I do. Maybe I’m wrong. Either way, it would be good record for next person trying to add support of another HBase version. But I did not want to post your message without permission, so I’ll reply directly.

Your point #1 about installer script is a good one. But I‘d say that the installer script could be enhanced to recognize which version of HBase is there and then move only correct TRX file. Either as part of your change or separately.

If you are changing build to support apache hbase1.1, then why are you trying to retain hbase1.0?  If we want both supported, we should be able to choose at install time not at build time.

It is hbase-trx makefile that determines which TRX files are built. If developr wants to switch hbase version, they should change makefile, and maybe the install_features file too. But the sqenvcom.sh file should not read the install_features file.  Your changes work differently than all the other versions of TRX.  I would prefer consistency.

--Steve

From: Ma, Sheng-Chen (Aven) [mailto:shengchen.ma@esgyn.cn<ma...@esgyn.cn>]
Sent: Thursday, June 2, 2016 3:02 AM
To: Steve Varnau <st...@esgyn.com>>
Subject: about pull 503

Hi Steve:

I send this mail to discuss #503 (https://github.com/apache/incubator-trafodion/pull/503)
As your comment is a little confused me, I’d like to make sure something.

As u commented:

In other cases, we support multiple versions simultaneously by generating multiple TRX files. I'm not sure we want to add more TRX files, but I'm also not sure we want to switch how the build works based on content of install_features file.

Previously it works the other way round -- the install_features file indicates what TRX files are available, hence which distros are supported.

This change will not add new trx file ,it just change hbase-trx-apache.jar from 1.0 to 1.1, It’s not good idea gen two apache-trx.jar, because there are two reason, one is our install script will add hbase-trx-apache*.jar to classpath, see /incubator-trafodion/install/installer/traf_apache_mods line51. Two is if 2 different version hbase-trx-apache*.jar added to classpath, hbase will only use the first meet class in the jar package, it may lead to conflict.

About install_features file. I am not sure we want to switch how the build works based on content of install_features file either. But the only way I can distinguish which hbase version to use is this file. If there is another place to distinguish this ,pls tell me ,thanks.

About your last sentence , I am really confuse, is that means we indeed use install_features to distinguish hbase version?


Thanks,
Aven

Re: 答复: about pull 503

[Amanda Moran <am...@esgyn.com>]

Hi there Aven-

You can you install_features, actually you must so that the installer knows
what version of HBase is supported in that particular package. The
installer can install all versions of trafodion. So there will need to be
HBase 1.0 support in the installer and HBase 1.1 . install_features is used
during installation not during sqenvcom.sh. Take a look at
traf_config_check to see the details.

Thanks.

On Fri, Jun 3, 2016 at 1:01 AM, Ma, Sheng-Chen (Aven) <shengchen.ma@esgyn.cn
> wrote:

> hi Steve:
> I think u are right . I will do some change which will not rely on
> install_feature. Then I will have this discussion on dev list.
>
> Thanks
> Aven
>
>
> 发件人: Steve Varnau [mailto:steve.varnau@esgyn.com]
> 发送时间: 2016年6月3日 6:40
> 收件人: Ma, Sheng-Chen (Aven) <sh...@esgyn.cn>
> 抄送: Amanda Moran <am...@esgyn.com>
> 主题: RE: about pull 503
>
> Hi Aven,
>
> I think it would be really good to have this discussion on the dev list or
> on github.  Others may also be confused by my remarks or may have different
> opinions than I do. Maybe I’m wrong. Either way, it would be good record
> for next person trying to add support of another HBase version. But I did
> not want to post your message without permission, so I’ll reply directly.
>
> Your point #1 about installer script is a good one. But I‘d say that the
> installer script could be enhanced to recognize which version of HBase is
> there and then move only correct TRX file. Either as part of your change or
> separately.
>
> If you are changing build to support apache hbase1.1, then why are you
> trying to retain hbase1.0?  If we want both supported, we should be able to
> choose at install time not at build time.
>
> It is hbase-trx makefile that determines which TRX files are built. If
> developr wants to switch hbase version, they should change makefile, and
> maybe the install_features file too. But the sqenvcom.sh file should not
> read the install_features file.  Your changes work differently than all the
> other versions of TRX.  I would prefer consistency.
>
> --Steve
>
> From: Ma, Sheng-Chen (Aven) [mailto:shengchen.ma@esgyn.cn<mailto:
> shengchen.ma@esgyn.cn>]
> Sent: Thursday, June 2, 2016 3:02 AM
> To: Steve Varnau <st...@esgyn.com>>
> Subject: about pull 503
>
> Hi Steve:
>
> I send this mail to discuss #503 (
> https://github.com/apache/incubator-trafodion/pull/503)
> As your comment is a little confused me, I’d like to make sure something.
>
> As u commented:
>
> In other cases, we support multiple versions simultaneously by generating
> multiple TRX files. I'm not sure we want to add more TRX files, but I'm
> also not sure we want to switch how the build works based on content of
> install_features file.
>
> Previously it works the other way round -- the install_features file
> indicates what TRX files are available, hence which distros are supported.
>
> This change will not add new trx file ,it just change hbase-trx-apache.jar
> from 1.0 to 1.1, It’s not good idea gen two apache-trx.jar, because there
> are two reason, one is our install script will add hbase-trx-apache*.jar to
> classpath, see /incubator-trafodion/install/installer/traf_apache_mods
> line51. Two is if 2 different version hbase-trx-apache*.jar added to
> classpath, hbase will only use the first meet class in the jar package, it
> may lead to conflict.
>
> About install_features file. I am not sure we want to switch how the build
> works based on content of install_features file either. But the only way I
> can distinguish which hbase version to use is this file. If there is
> another place to distinguish this ,pls tell me ,thanks.
>
> About your last sentence , I am really confuse, is that means we indeed
> use install_features to distinguish hbase version?
>
>
> Thanks,
> Aven
>
>


-- 
Thanks,

Amanda Moran