You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/04/10 02:01:37 UTC
[GitHub] [groovy] paulk-asert opened a new pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
paulk-asert opened a new pull request #1552:
URL: https://github.com/apache/groovy/pull/1552
…e parser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] timyates commented on a change in pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
timyates commented on a change in pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#discussion_r611042118
##########
File path: src/test/groovy/StringTest.groovy
##########
@@ -241,6 +241,11 @@ foo
text = $/$$$$$//$
assert text == '$$/'
+
+ //GROOVY-10024
+ def s1 = $/abc\/$
+ def s2 = $/def/$
+ assert s1.size() == 4 && s2.size() == 3
Review comment:
Awesome as always Paul 😎👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#issuecomment-817106706
LGTM. Let's wait for the test result:
https://github.com/danielsun1106/groovy-parser/tree/GROOVY-10024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit merged pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1552:
URL: https://github.com/apache/groovy/pull/1552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#issuecomment-817205968
Proposed PR merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] timyates commented on a change in pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
timyates commented on a change in pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#discussion_r611026826
##########
File path: src/test/groovy/StringTest.groovy
##########
@@ -241,6 +241,11 @@ foo
text = $/$$$$$//$
assert text == '$$/'
+
+ //GROOVY-10024
+ def s1 = $/abc\/$
+ def s2 = $/def/$
+ assert s1.size() == 4 && s2.size() == 3
Review comment:
Does
```
def s1 = $/Failing string\\/$
```
With double backslash at the end work (as per the Jira example)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#issuecomment-817109100
The test result is green ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] pbielicki commented on a change in pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
pbielicki commented on a change in pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#discussion_r611023878
##########
File path: src/test/groovy/StringTest.groovy
##########
@@ -241,6 +241,11 @@ foo
text = $/$$$$$//$
assert text == '$$/'
+
+ //GROOVY-10024
+ def s1 = $/abc\/$
+ def s2 = $/def/$
+ assert s1.size() == 4 && s2.size() == 3
Review comment:
I’d assert the expected values instead of the size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] pbielicki commented on a change in pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
pbielicki commented on a change in pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#discussion_r611023878
##########
File path: src/test/groovy/StringTest.groovy
##########
@@ -241,6 +241,11 @@ foo
text = $/$$$$$//$
assert text == '$$/'
+
+ //GROOVY-10024
+ def s1 = $/abc\/$
+ def s2 = $/def/$
+ assert s1.size() == 4 && s2.size() == 3
Review comment:
I’d assert expected values instead of size alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a change in pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on a change in pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#discussion_r611036046
##########
File path: src/test/groovy/StringTest.groovy
##########
@@ -241,6 +241,11 @@ foo
text = $/$$$$$//$
assert text == '$$/'
+
+ //GROOVY-10024
+ def s1 = $/abc\/$
+ def s2 = $/def/$
+ assert s1.size() == 4 && s2.size() == 3
Review comment:
The double backslash case works - I'll adjust the test accordingly and also with expected values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org