You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/09/14 12:10:10 UTC
[commons-statistics] 05/08: Scale the expected for the Chi-square
test
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 1469869803ce388c76aa1b341a56eff8f261d8c1
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Sep 14 12:09:45 2021 +0100
Scale the expected for the Chi-square test
---
.../statistics/distribution/ContinuousDistributionAbstractTest.java | 5 ++++-
.../statistics/distribution/DiscreteDistributionAbstractTest.java | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
index 2ccd017..5412fea 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
@@ -23,6 +23,7 @@ import java.util.Collections;
import org.apache.commons.math3.analysis.UnivariateFunction;
import org.apache.commons.math3.analysis.integration.BaseAbstractUnivariateIntegrator;
import org.apache.commons.math3.analysis.integration.IterativeLegendreGaussIntegrator;
+import org.apache.commons.math3.util.MathArrays;
import org.apache.commons.rng.simple.RandomSource;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.AfterEach;
@@ -467,8 +468,10 @@ abstract class ContinuousDistributionAbstractTest {
final double[] quartiles = TestUtils.getDistributionQuartiles(getDistribution());
final double[] expected = {0.25, 0.25, 0.25, 0.25};
- // Use fixed seed.
final int sampleSize = 1000;
+ MathArrays.scaleInPlace(sampleSize, expected);
+
+ // Use fixed seed.
final ContinuousDistribution.Sampler sampler =
getDistribution().createSampler(RandomSource.create(RandomSource.WELL_19937_C, 123456789L));
final double[] sample = TestUtils.sample(sampleSize, sampler);
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
index 763c67f..ebafcbb 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
@@ -17,6 +17,7 @@
package org.apache.commons.statistics.distribution;
import java.util.Arrays;
+import org.apache.commons.math3.util.MathArrays;
import org.apache.commons.rng.simple.RandomSource;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Assertions;
@@ -484,8 +485,10 @@ abstract class DiscreteDistributionAbstractTest {
Assertions.fail("Not enough of the PMF is tested during sampling: " + sum);
}
- // Use fixed seed.
final int sampleSize = 1000;
+ MathArrays.scaleInPlace(sampleSize, expected);
+
+ // Use fixed seed.
final DiscreteDistribution.Sampler sampler =
getDistribution().createSampler(RandomSource.create(RandomSource.WELL_512_A, 1000));
final int[] sample = TestUtils.sample(sampleSize, sampler);