You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/07/21 04:13:38 UTC

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3209: [#3208] IsolationDiscoveryFilter实例隔离的时候只更新了data,children如果已经缓存了,则不会更新,所以起不到隔离作用

codecov-commenter commented on PR #3209:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3209#issuecomment-1191017435

   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3209](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (655d1b0) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/37df78fec71f58442cc05051c7cbdc0c684fb2b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37df78f) will **increase** coverage by `0.00%`.
   > The diff coverage is `81.81%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #3209   +/-   ##
   =========================================
     Coverage     77.46%   77.46%           
     Complexity     1439     1439           
   =========================================
     Files          1629     1629           
     Lines         43413    43431   +18     
     Branches       3653     3657    +4     
   =========================================
   + Hits          33628    33642   +14     
   - Misses         8272     8274    +2     
   - Partials       1513     1515    +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...b/loadbalance/filter/IsolationDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZmlsdGVyL0lzb2xhdGlvbkRpc2NvdmVyeUZpbHRlci5qYXZh) | `93.61% <81.81%> (-3.76%)` | :arrow_down: |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.31% <0.00%> (+0.38%)` | :arrow_up: |
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org