You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/12/28 07:13:51 UTC

[GitHub] [incubator-inlong] TszKitLo40 commented on a change in pull request #2067: [INLONG-2066] Confirm the message correctly in Go SDK

TszKitLo40 commented on a change in pull request #2067:
URL: https://github.com/apache/incubator-inlong/pull/2067#discussion_r775758008



##########
File path: inlong-tubemq/tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -280,7 +280,8 @@ func (c *consumer) Confirm(confirmContext string, consumed bool) (*ConsumerResul
 		return nil, errs.New(errs.RetErrConfirmTimeout, "Not found the partition by confirm_context!")
 	}
 
-	rsp, err := c.sendConfirmReq2Broker(partition)
+	defer c.rmtDataCache.ReleasePartition(true, c.subInfo.IsFiltered(topic), confirmContext, consumed)

Review comment:
       Partition will be released before leaving this function, so the request will be sent to broker.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org