You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2008/12/19 10:27:22 UTC
svn commit: r727985 - in
/maven/core-integration-testing/trunk/core-it-suite/src/test:
java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java
resources/it0144/pom.xml
Author: bentmann
Date: Fri Dec 19 01:27:22 2008
New Revision: 727985
URL: http://svn.apache.org/viewvc?rev=727985&view=rev
Log:
o Extended IT to consider MNG-2097
Modified:
maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java
maven/core-integration-testing/trunk/core-it-suite/src/test/resources/it0144/pom.xml
Modified: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java?rev=727985&r1=727984&r2=727985&view=diff
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java (original)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java Fri Dec 19 01:27:22 2008
@@ -76,9 +76,15 @@
expected.add( "test-compile" );
if ( matchesVersionRange( "(2.0.4,)" ) )
{
+ // MNG-1508
expected.add( "process-test-classes" );
}
expected.add( "test" );
+ if ( matchesVersionRange( "(2.1.0-M1,)" ) )
+ {
+ // MNG-2097
+ expected.add( "prepare-package" );
+ }
expected.add( "package" );
if ( matchesVersionRange( "(2.0.1,)" ) )
{
Modified: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/it0144/pom.xml
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/resources/it0144/pom.xml?rev=727985&r1=727984&r2=727985&view=diff
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/resources/it0144/pom.xml (original)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/resources/it0144/pom.xml Fri Dec 19 01:27:22 2008
@@ -206,6 +206,17 @@
</configuration>
</execution>
<execution>
+ <id>prepare-package</id>
+ <phase>prepare-package</phase>
+ <goals>
+ <goal>log-string</goal>
+ </goals>
+ <configuration>
+ <logFile>target/phases.log</logFile>
+ <string>prepare-package</string>
+ </configuration>
+ </execution>
+ <execution>
<id>package</id>
<phase>package</phase>
<goals>
Re: svn commit: r727985 - in /maven/core-integration-testing/trunk/core-it-suite/src/test:
java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java resources/it0144/pom.xml
Posted by Benjamin Bentmann <be...@udo.edu>.
Brett Porter wrote:
> Didn't notice that one in there at the time.
Not surprising given the few tests we have ;-). I was already wondering
whether we should create some index/text file that groups the existing
ITs into categories (e.g. dependency resolution, lifecycle,
interpolation) to get a quicker overview of what features are tested or
not and if where they are tested.
> I think we can remove the 2097 IT with this - the only extra thing it
> tests is the ability to run that phase from the command line. WDYT?
+1 to remove the standalone IT for 2097 in favor of it0144, you were
just quicker to ask. ITs are a powerful but rather expensive means of
testing so I believe it is important to test individual features like
the lifecycle with one comprehensive test instead of having many small
tests which check only sub parts like individual phases.
As for the CLI invocation part of the 2097 IT: The other IT invokes
three phases from the CLI (clean, deploy and site-deploy). Assuming that
there is no special treatment for other phases in the core code, I
personally feel quite comfortable if we do not explicitly check that
another phase like "prepare-package" can be invoked from CLI as well.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r727985 - in /maven/core-integration-testing/trunk/core-it-suite/src/test: java/org/apache/maven/it/MavenIT0144LifecycleExecutionOrderTest.java resources/it0144/pom.xml
Posted by Brett Porter <br...@apache.org>.
On 19/12/2008, at 8:27 PM, bentmann@apache.org wrote:
> Author: bentmann
> Date: Fri Dec 19 01:27:22 2008
> New Revision: 727985
>
> URL: http://svn.apache.org/viewvc?rev=727985&view=rev
> Log:
> o Extended IT to consider MNG-2097
Thanks! Didn't notice that one in there at the time.
I think we can remove the 2097 IT with this - the only extra thing it
tests is the ability to run that phase from the command line. WDYT?
- Brett
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org