You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/11/13 00:54:19 UTC
Review Request 27941: Fix review bot to use correct latest diff time.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27941/
-----------------------------------------------------------
Review request for Aurora and Joshua Cohen.
Repository: aurora
Description
-------
I broke this in my recent hasty feature addition - i was accidentally using the latest review time to represent the latest diff time, causing reviews with new diffs to not be built.
Diffs
-----
build-support/jenkins/review_feedback.py d59818e8492869a0f3d7bf94727eba69e1b28033
Diff: https://reviews.apache.org/r/27941/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27941: Fix review bot to use correct latest diff
time.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27941/#review61137
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Nov. 12, 2014, 11:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27941/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:54 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I broke this in my recent hasty feature addition - i was accidentally using the latest review time to represent the latest diff time, causing reviews with new diffs to not be built.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py d59818e8492869a0f3d7bf94727eba69e1b28033
>
> Diff: https://reviews.apache.org/r/27941/diff/
>
>
> Testing
> -------
>
> Ran locally and it's now picking up reviews needing to be built.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27941: Fix review bot to use correct latest diff
time.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27941/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 11:54 p.m.)
Review request for Aurora and Joshua Cohen.
Repository: aurora
Description
-------
I broke this in my recent hasty feature addition - i was accidentally using the latest review time to represent the latest diff time, causing reviews with new diffs to not be built.
Diffs
-----
build-support/jenkins/review_feedback.py d59818e8492869a0f3d7bf94727eba69e1b28033
Diff: https://reviews.apache.org/r/27941/diff/
Testing (updated)
-------
Ran locally and it's now picking up reviews needing to be built.
Thanks,
Bill Farner