You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/05/11 08:28:53 UTC

Review Request 59169: Hive 2.0 View Table Statistics overflows Integer Type convert to Long

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59169/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20981
    https://issues.apache.org/jira/browse/AMBARI-20981


Repository: ambari


Description
-------

converted the Integers to Longs to avoid overflow in case big ints are coming from hive


Diffs
-----

  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 5d0f307a52 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java 711cab9183 


Diff: https://reviews.apache.org/r/59169/diff/1/


Testing
-------

manual testing done.


Thanks,

Nitiraj Rathore


Re: Review Request 59169: Hive 2.0 View Table Statistics overflows Integer Type convert to Long

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59169/#review174622
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 11, 2017, 8:28 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59169/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 8:28 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20981
>     https://issues.apache.org/jira/browse/AMBARI-20981
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> converted the Integers to Longs to avoid overflow in case big ints are coming from hive
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 5d0f307a52 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java 711cab9183 
> 
> 
> Diff: https://reviews.apache.org/r/59169/diff/1/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 59169: Hive 2.0 View Table Statistics overflows Integer Type convert to Long

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59169/#review174627
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On May 11, 2017, 8:28 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59169/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 8:28 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20981
>     https://issues.apache.org/jira/browse/AMBARI-20981
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> converted the Integers to Longs to avoid overflow in case big ints are coming from hive
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 5d0f307a52 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java 711cab9183 
> 
> 
> Diff: https://reviews.apache.org/r/59169/diff/1/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 59169: Hive 2.0 View Table Statistics overflows Integer Type convert to Long

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59169/#review174623
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On May 11, 2017, 8:28 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59169/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 8:28 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20981
>     https://issues.apache.org/jira/browse/AMBARI-20981
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> converted the Integers to Longs to avoid overflow in case big ints are coming from hive
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 5d0f307a52 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java 711cab9183 
> 
> 
> Diff: https://reviews.apache.org/r/59169/diff/1/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>