You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 10:15:39 UTC
[GitHub] [arrow] assignUser opened a new pull request, #13063: MINOR: Use bundled gtest
assignUser opened a new pull request, #13063:
URL: https://github.com/apache/arrow/pull/13063
This should fix the nightly test failure `test-build-vcpkg-win`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117517586
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117149291
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117331300
@assignUser Thanks for the PR! As a general guideline, can you try to make the PR title and description a bit more explicit?
(they all end up in the commit message, for the record)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r866322677
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
It seems that ARROW-14560 is another problem and it has been fixed in upstream.
Could you open a new JIRA issue for it?
How about just removing https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L80-L86 ? The latest may solve the problem described in the comment.
If the problem isn't solved yet, we should report it to the conda's GTest package. We can use `if(ARROW_DEPENDENCY_SOURCE STREQUAL "CONDA" AND MSVC AND "${GTest_SOURCE}" STREQUAL "")` condition as a workaround for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r864846009
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
Hmm, how does this work on Windows? "system" would mean system-provided packages on Linux, but I don't think those exist at all on Windows.
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
cc @kou for advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117146279
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117519118
Revision: 10e6832fe159eef3ea62cecd142044c10e615608
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2016](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2016)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2016-github-test-build-vcpkg-win)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r866070837
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
Ok I'll close this PR and I think this might be an appropriate [JIRA](https://issues.apache.org/jira/browse/ARROW-14560) to use? I would gladly take your suggestion on how to fix this @kou , should this test only be used in case we also use conda? As it seems to work with vcpkg,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r865396351
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
We should not do this. We should fix https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L80-L86 instead.
(This is not a MINOR task.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r864958276
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
It looks like [it worked](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2012-github-test-build-vcpkg-win) (vcpkg is still installing 1.10 but the error is gone)? It now fails due to missing tzdata, which should be fixable via the download script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser closed pull request #13063: MINOR: [C++] Use bundled gtest
Posted by GitBox <gi...@apache.org>.
assignUser closed pull request #13063: MINOR: [C++] Use bundled gtest
URL: https://github.com/apache/arrow/pull/13063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117147240
Revision: a29f8ab4be5085d0227616fd4c8451d21088db49
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2011](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2011)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2011-github-test-build-vcpkg-win)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117150415
Revision: f74d85e80ef7d87847b8ddddf492385151a0afa0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2012](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2012)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2012-github-test-build-vcpkg-win)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13063: MINOR: Use bundled gtest
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13063:
URL: https://github.com/apache/arrow/pull/13063#issuecomment-1117331853
(also, please include the component in the PR title using the same convention as on JIRA, for example `MINOR: [C++] ...`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org