You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2017/08/30 20:23:49 UTC
[Impala-ASF-CR] Updates several .gitignore files.
Vuk Ercegovac has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7902
Change subject: Updates several .gitignore files.
......................................................................
Updates several .gitignore files.
Ran into these when compiling (generated files from kudu),
eclipse setup, and testing.
Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
---
M .gitignore
M be/.gitignore
M fe/.gitignore
M testdata/.gitignore
M tests/.gitignore
5 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/7902/1
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7902/2/testdata/.gitignore
File testdata/.gitignore:
PS2, Line 26: datasets/visa
: workloads/visa
It's not clear to me this sort of thing should be disclosed. Apache Impala does not generate any such file patterns.
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7902/2/testdata/.gitignore
File testdata/.gitignore:
PS2, Line 25:
> We have tried to excise mentions of CDH (from when Apache Impala was open s
right, I've removed it in the follow-up patch.
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7902/2/testdata/.gitignore
File testdata/.gitignore:
PS2, Line 25: cluster/cdh5
We have tried to excise mentions of CDH (from when Apache Impala was open source with Cloudera) in the code base. I'm not sure we should be bringing them back. This was effectively removed here http://gerrit.cloudera.org:8080/4187
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7902/1/.gitignore
File .gitignore:
PS1, Line 41: benchmark_results.json
benchmark_results*.json ?
http://gerrit.cloudera.org:8080/#/c/7902/1/be/.gitignore
File be/.gitignore:
PS1, Line 10: src/kudu/rpc/rtest.proxy.*
: src/kudu/rpc/rtest.service.*
May help to do *.proxy.h *.proxy.cc *.service.h *.service.cc, similar to *.pb.h and *.pb.cc below.
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: Updates several .gitignore files.
......................................................................
Updates several .gitignore files.
Ran into these when compiling (generated files from kudu),
eclipse setup, and testing.
Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Reviewed-on: http://gerrit.cloudera.org:8080/7902
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M .gitignore
M be/.gitignore
M fe/.gitignore
M testdata/.gitignore
M tests/.gitignore
5 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, but someone else must approve
Michael Ho: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7902/1/.gitignore
File .gitignore:
PS1, Line 41: benchmark_results*.jso
> benchmark_results*.json ?
Done
http://gerrit.cloudera.org:8080/#/c/7902/1/be/.gitignore
File be/.gitignore:
PS1, Line 10: *.proxy.h
: *.proxy.cc
> May help to do *.proxy.h *.proxy.cc *.service.h *.service.cc, similar to *.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7902
to look at the new patch set (#3).
Change subject: Updates several .gitignore files.
......................................................................
Updates several .gitignore files.
Ran into these when compiling (generated files from kudu),
eclipse setup, and testing.
Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
---
M .gitignore
M be/.gitignore
M fe/.gitignore
M testdata/.gitignore
M tests/.gitignore
5 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/7902/3
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1179/
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has uploaded a new patch set (#2).
Change subject: Updates several .gitignore files.
......................................................................
Updates several .gitignore files.
Ran into these when compiling (generated files from kudu),
eclipse setup, and testing.
Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
---
M .gitignore
M be/.gitignore
M fe/.gitignore
M testdata/.gitignore
M tests/.gitignore
5 files changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/7902/2
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] Updates several .gitignore files.
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change.
Change subject: Updates several .gitignore files.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7902/2/testdata/.gitignore
File testdata/.gitignore:
PS2, Line 26: # Generated block ids (hdfs ids) for each table
: block-ids
> It's not clear to me this sort of thing should be disclosed. Apache Impala
good catch, removed.
--
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-HasComments: Yes