You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/11 00:17:17 UTC
Review Request 71053: Added reserved, offered,
allocated resources to the /roles endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789
Repository: mesos
Description
-------
This provides helpful information for debugging, as well as for the
webui to display in the roles table.
Diffs
-----
src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
Diff: https://reviews.apache.org/r/71053/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71053: Added reserved, offered,
allocated resources to the /roles endpoint.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/#review216518
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71050, 71051, 71052, 71053]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 11, 2019, 12:17 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71053/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 12:17 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides helpful information for debugging, as well as for the
> webui to display in the roles table.
>
>
> Diffs
> -----
>
> src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
> src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
>
>
> Diff: https://reviews.apache.org/r/71053/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71053: Added reserved, offered,
allocated resources to the /roles endpoint.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/#review216514
-----------------------------------------------------------
Ship it!
See my comment in https://reviews.apache.org/r/71050/
- Meng Zhu
On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71053/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 5:17 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides helpful information for debugging, as well as for the
> webui to display in the roles table.
>
>
> Diffs
> -----
>
> src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
> src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
>
>
> Diff: https://reviews.apache.org/r/71053/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71053: Added reserved, offered,
allocated resources to the /roles endpoint.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/
-----------------------------------------------------------
(Updated July 11, 2019, 6:36 p.m.)
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Changes
-------
- Updated the test to include ports output.
Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789
Repository: mesos
Description
-------
This provides helpful information for debugging, as well as for the
webui to display in the roles table.
Diffs (updated)
-----
src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
Diff: https://reviews.apache.org/r/71053/diff/2/
Changes: https://reviews.apache.org/r/71053/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler