[GitHub] [shiro] bmhm edited a comment on issue #209: [SHIRO-530] INI parser does not properly handled backslashes at end o…

[GitBox <gi...@apache.org>]

bmhm edited a comment on issue #209: [SHIRO-530] INI parser does not properly handled backslashes at end o…
URL: https://github.com/apache/shiro/pull/209#issuecomment-606185214
 
 
   TODO:
   
    - [ ] document capture groups
    - [x] remove `\\` from first capture group. It just makes no sense. Disappearing is unexpected. Or just let it disappear from the key only?
    - [ ] to make it more similar to the existing behaviour, we could just strip backsashes from the key. `final String key = matcher.group(1).replaceAll("\\\\", "");`.
    - [ ] Please explain this test (especially it's purpose). It makes no sense imho. This would be the only test failing then.
   ```java
           test = "Truth\\=Beauty";
           kv = Ini.Section.splitKeyValue(test);
           assertEquals("Truth", kv[0]);
           assertEquals("Beauty", kv[1]);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services