You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/08/27 07:47:44 UTC
[PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
adoroszlai opened a new pull request, #544:
URL: https://github.com/apache/ozone-site/pull/544
## What changes were proposed in this pull request?
Dependabot started updating `apache/infrastructure-actions/allowlist-check` (e.g. #542) when there were no changes in the action, only other parts of the infra repo. The action is pinned by SHA without tag comment. This PR adds tag comment (and changes SHA to match the tag) to prevent these unnecessary dependabot updates.
https://issues.apache.org/jira/browse/HDDS-16305
## How was this patch tested?
Same fix verified in `ratis-thirdparty` repo, dependabot closed the unnecessary pull requests (e.g. https://github.com/apache/ratis-thirdparty/pull/183#issuecomment-5435380599).
asf-allowlist-check: https://github.com/adoroszlai/ozone-site/actions/runs/33050066659
CI: https://github.com/adoroszlai/ozone-site/actions/runs/33050066783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #544:
URL: https://github.com/apache/ozone-site/pull/544#discussion_r3870804603
##########
.github/workflows/asf-allowlist-check.yaml:
##########
@@ -45,6 +45,7 @@ jobs:
with:
persist-credentials: false
- name: Check actions
- uses: apache/infrastructure-actions/allowlist-check@69afc125e535c4c41e7f1b7470f583087e0f344b
+ # yamllint disable-line rule:line-length
Review Comment:
Yes, it's needed to prevent yamllint [failure](https://github.com/adoroszlai/ozone-site/actions/runs/33047440255/job/98434655500#step:6:13):
```
./.github/workflows/asf-allowlist-check.yaml
48:121 error line too long (123 > 120 characters) (line-length)
```
(yamllint does not exist in other Ozone repos, only in `ozone-site`, and it, somewhat annoyingly, applies to github workflow files, too.)
I tried to [break the long line](https://github.com/adoroszlai/ozone-site/commit/1a20893f27be84a393bfbc458b99d9c3d3ccf926), but the workflow [failed](https://github.com/adoroszlai/ozone-site/actions/runs/33048042930/job/98436585820#step:1:24) elsewhere:
```
Error: Unable to resolve action `apache/infrastructure-actions@61dcea11f19e2bbe1263f14d72235e8da17d3ad0 # allowlist-check/v1.0.0`, unable to find version `61dcea11f19e2bbe1263f14d72235e8da17d3ad0 # allowlist-check/v1.0.0`
```
I took it from similar change in `airflow`:
https://github.com/apache/airflow/blob/9ad206a01def2dc6fffe9a7d237c643d66645078/.github/workflows/asf-allowlist-check.yml#L34-L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on code in PR #544:
URL: https://github.com/apache/ozone-site/pull/544#discussion_r3870828379
##########
.github/workflows/asf-allowlist-check.yaml:
##########
@@ -45,6 +45,7 @@ jobs:
with:
persist-credentials: false
- name: Check actions
- uses: apache/infrastructure-actions/allowlist-check@69afc125e535c4c41e7f1b7470f583087e0f344b
+ # yamllint disable-line rule:line-length
Review Comment:
Thanks for the explanation, makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #544:
URL: https://github.com/apache/ozone-site/pull/544#issuecomment-5437941328
Thanks @dombizita for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #544:
URL: https://github.com/apache/ozone-site/pull/544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #544:
URL: https://github.com/apache/ozone-site/pull/544#discussion_r3870804603
##########
.github/workflows/asf-allowlist-check.yaml:
##########
@@ -45,6 +45,7 @@ jobs:
with:
persist-credentials: false
- name: Check actions
- uses: apache/infrastructure-actions/allowlist-check@69afc125e535c4c41e7f1b7470f583087e0f344b
+ # yamllint disable-line rule:line-length
Review Comment:
Yes, it's needed to prevent yamllint [failure](https://github.com/adoroszlai/ozone-site/actions/runs/33047440255/job/98434655500#step:6:13):
```
./.github/workflows/asf-allowlist-check.yaml
48:121 error line too long (123 > 120 characters) (line-length)
```
I tried to [break the long line](https://github.com/adoroszlai/ozone-site/commit/1a20893f27be84a393bfbc458b99d9c3d3ccf926), but the workflow [failed](https://github.com/adoroszlai/ozone-site/actions/runs/33048042930/job/98436585820#step:1:24) elsewhere:
```
Error: Unable to resolve action `apache/infrastructure-actions@61dcea11f19e2bbe1263f14d72235e8da17d3ad0 # allowlist-check/v1.0.0`, unable to find version `61dcea11f19e2bbe1263f14d72235e8da17d3ad0 # allowlist-check/v1.0.0`
```
I took it from similar change in `airflow`:
https://github.com/apache/airflow/blob/9ad206a01def2dc6fffe9a7d237c643d66645078/.github/workflows/asf-allowlist-check.yml#L34-L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16305. Add version tag for pinned infra actions [ozone-site]
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on code in PR #544:
URL: https://github.com/apache/ozone-site/pull/544#discussion_r3870770549
##########
.github/workflows/asf-allowlist-check.yaml:
##########
@@ -45,6 +45,7 @@ jobs:
with:
persist-credentials: false
- name: Check actions
- uses: apache/infrastructure-actions/allowlist-check@69afc125e535c4c41e7f1b7470f583087e0f344b
+ # yamllint disable-line rule:line-length
Review Comment:
Is this needed? Does it do anything commented out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org