You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 09:29:34 UTC

[I] [Bug] Login should reject missing request body before authentication [rocketmq-dashboard]

Aias00 opened a new issue, #840:
URL: https://github.com/apache/rocketmq-dashboard/issues/840

   ### What happened?
   
   AuthController passes the LoginDTO directly to AuthService, and AuthService logs request.getUsername before validating the request object. If a null LoginDTO reaches the service, the login path can throw NullPointerException instead of returning a clear client error.
   
   ### Expected behavior
   
   A missing login request body should be rejected with a clear 400 response, and AuthService should also guard against null requests for direct service callers.
   
   ### Why this matters
   
   This belongs to BASE-01 login and permission handling. Authentication endpoints should fail predictably and should not turn malformed client requests into server errors.
   
   ### Candidate fix
   
   - Make the controller reject null login request bodies with BusinessException 400
   - Add a service-level null guard before logging fields
   - Add focused controller and service tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Login should reject missing request body before authentication [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #840: [Bug] Login should reject missing request body before authentication
URL: https://github.com/apache/rocketmq-dashboard/issues/840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Login should reject missing request body before authentication [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #840:
URL: https://github.com/apache/rocketmq-dashboard/issues/840#issuecomment-5177577107

   Resolved by #947 (merged into rocketmq-studio as 0f2b130).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org