You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by faisal-hameed <gi...@git.apache.org> on 2016/03/10 19:04:22 UTC

[GitHub] httpcore pull request: Code quality fix - Useless parentheses arou...

GitHub user faisal-hameed opened a pull request:

    https://github.com/apache/httpcore/pull/23

    Code quality fix - Useless parentheses around expressions should be removed to prevent any misunderstanding.

    This pull request is focused on resolving occurrences of Sonar rule 
    squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding.
    You can find more information about the issue here: 
    https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck
    
    Please let me know if you have any questions.
    
    Faisal Hameed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DevFactory/httpcore release/useless-parentheses-should-be-removed-fix-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcore/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 6f24b95f90b88ebaf61f87e38ce4328947da2f67
Author: Faisal Hameed <fa...@devfactory.com>
Date:   2016-03-09T18:25:58Z

    Fixing squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] httpcore pull request #23: Code quality fix - Useless parentheses around exp...

Posted by faisal-hameed <gi...@git.apache.org>.
Github user faisal-hameed closed the pull request at:

    https://github.com/apache/httpcore/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] httpcore pull request: Code quality fix - Useless parentheses arou...

Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:

    https://github.com/apache/httpcore/pull/23#issuecomment-194992409
  
    Hi,
    
    Thank you for your patch!
    
    Committed revision 1734440.
    
    Gary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org