[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #783: HDDS-2976. Recon throws error while trying to get snapshot over https
URL: https://github.com/apache/hadoop-ozone/pull/783#discussion_r405260217
 
 

 ##########
 File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconUtils.java
 ##########
 @@ -166,9 +168,11 @@ public int read() throws IOException {
       }
     });
 
-    InputStream inputStream = new ReconUtils()
-        .makeHttpCall(httpClientMock, url);
-    String contents = IOUtils.toString(inputStream, Charset.defaultCharset());
+    String contents;
+    try (InputStream inputStream = new ReconUtils()
+        .makeHttpCall(httpClientMock, url)) {
 
 Review comment:
   Can we modify the unit test to test the new makeHttpCall API?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org