You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2015/10/02 20:50:56 UTC
[GitHub] couchdb-fabric pull request: Fix eunit tests.
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-fabric/pull/32
Fix eunit tests.
Mock couch_log alongside couch_stats.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-fabric fix-eunit-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fabric/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 25e9da562212f1f67e1face58418dfc82c621b7c
Author: Nick Vatamaniuc <va...@gmail.com>
Date: 2015-10-02T18:47:10Z
Fix eunit tests.
Mock couch_log alongside couch_stats.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-145886951
For stats mocking there was a reason - to suppress thousands of "unknown metric" log messages caused by not loaded apps which provides those metrics. For mocking log I don't see any except to avoid some issues caused by logging setup: or we start couch_log with wrong parameters, or we didn't provide any backend for it and it cannot properly fallback to io:format/2 - don't know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-146275055
so what are we going to do here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-145885022
if we are mocking log and stats over and over, maybe we'd better to make them actually work within tests and keep their working start/stop combination somewhere like https://github.com/apache/couchdb-couch/blob/master/src/test_util.erl, so it could be reused across the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-145539829
I mocked couch_log because it already mocked couch_stats, didn't seem to start a lot of applications, just kind of seemed more lightweight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-145532377
Why do we have mock logs all the time? /:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-146276976
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fabric/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request: Fix eunit tests.
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/32#issuecomment-146275752
Let's merge and file an issue to investigate into couch_log problem later. We'll hit the same problem anyway, not here, but somewhere else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---