You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "JingGe (via GitHub)" <gi...@apache.org> on 2023/11/24 18:56:35 UTC

[PR] [hotfix][doc] fix Retained Checkpoints link in checkpointing [flink]

JingGe opened a new pull request, #23795:
URL: https://github.com/apache/flink/pull/23795

   ## What is the purpose of the change
   
   fix link in the checkpointing doc
   
   ## Verifying this change
   
   This change is a trivial doc fix without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe merged PR #23795:
URL: https://github.com/apache/flink/pull/23795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #23795:
URL: https://github.com/apache/flink/pull/23795#discussion_r1404855432


##########
docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md:
##########
@@ -70,7 +70,7 @@ Checkpoint 其他的属性包括:
     该选项不能和 "checkpoints 间的最小时间"同时使用。
     
   - *externalized checkpoints*: 你可以配置周期存储 checkpoint 到外部系统中。Externalized checkpoints 将他们的元数据写到持久化存储上并且在 job 失败的时候*不会*被自动删除。
-    这种方式下,如果你的 job 失败,你将会有一个现有的 checkpoint 去恢复。更多的细节请看 [Externalized checkpoints 的部署文档]({{< ref "docs/ops/state/checkpoints" >}}#externalized-checkpoints)。
+    这种方式下,如果你的 job 失败,你将会有一个现有的 checkpoint 去恢复。更多的细节请看 [保留 checkpoints 的部署文档]({{< ref "docs/ops/state/checkpoints" >}}#保留-checkpoint)。

Review Comment:
   Hi @JingGe , thanks for your fix!
   
   I see Chinese doc missed some items compared to the English doc[1], would you mind adding them together? Such as:
   
   - checkpoint storage
   - unaligned checkpoints:
   - checkpoints with finished tasks:
   
   [1] https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/checkpointing/#enabling-and-configuring-checkpointing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on PR #23795:
URL: https://github.com/apache/flink/pull/23795#issuecomment-1826474695

   Thanks @1996fanrui for the review. Ticket is created: https://issues.apache.org/jira/browse/FLINK-33651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #23795:
URL: https://github.com/apache/flink/pull/23795#discussion_r1405147685


##########
docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md:
##########
@@ -70,7 +70,7 @@ Checkpoint 其他的属性包括:
     该选项不能和 "checkpoints 间的最小时间"同时使用。
     
   - *externalized checkpoints*: 你可以配置周期存储 checkpoint 到外部系统中。Externalized checkpoints 将他们的元数据写到持久化存储上并且在 job 失败的时候*不会*被自动删除。
-    这种方式下,如果你的 job 失败,你将会有一个现有的 checkpoint 去恢复。更多的细节请看 [Externalized checkpoints 的部署文档]({{< ref "docs/ops/state/checkpoints" >}}#externalized-checkpoints)。
+    这种方式下,如果你的 job 失败,你将会有一个现有的 checkpoint 去恢复。更多的细节请看 [保留 checkpoints 的部署文档]({{< ref "docs/ops/state/checkpoints" >}}#保留-checkpoint)。

Review Comment:
   @1996fanrui thanks for the hint. I will start a new PR to add those missing content.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix][doc] fix Retained Checkpoints link in checkpointing [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23795:
URL: https://github.com/apache/flink/pull/23795#issuecomment-1826002514

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5a678bf8a1c6277fdc636438550859eaca78d000",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5a678bf8a1c6277fdc636438550859eaca78d000",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a678bf8a1c6277fdc636438550859eaca78d000 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org