You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/05/29 07:05:41 UTC
[GitHub] [servicecomb-java-chassis] HaitaoDeng opened a new pull request, #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
HaitaoDeng opened a new pull request, #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011
[SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#issuecomment-1140459571
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3011](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b17d710) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/2e45749c4b758db48ed3473a0875cffae55ecefd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e45749) will **decrease** coverage by `0.00%`.
> The diff coverage is `72.09%`.
```diff
@@ Coverage Diff @@
## master #3011 +/- ##
============================================
- Coverage 77.61% 77.60% -0.01%
Complexity 1415 1415
============================================
Files 1611 1613 +2
Lines 43095 43118 +23
Branches 3630 3630
============================================
+ Hits 33447 33462 +15
- Misses 8150 8157 +7
- Partials 1498 1499 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...comb/tracing/zipkin/HttpClientResponseWrapper.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vSHR0cENsaWVudFJlc3BvbnNlV3JhcHBlci5qYXZh) | `50.00% <50.00%> (ø)` | |
| [...ecomb/tracing/zipkin/HttpClientRequestWrapper.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vSHR0cENsaWVudFJlcXVlc3RXcmFwcGVyLmphdmE=) | `70.00% <70.00%> (ø)` | |
| [...cecomb/tracing/zipkin/HttpServeRequestWrapper.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vSHR0cFNlcnZlUmVxdWVzdFdyYXBwZXIuamF2YQ==) | `75.00% <75.00%> (ø)` | |
| [...comb/tracing/zipkin/HttpServerResponseWrapper.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vSHR0cFNlcnZlclJlc3BvbnNlV3JhcHBlci5qYXZh) | `80.00% <80.00%> (ø)` | |
| [...rvicecomb/tracing/zipkin/TracingConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vVHJhY2luZ0NvbmZpZ3VyYXRpb24uamF2YQ==) | `86.36% <100.00%> (ø)` | |
| [...icecomb/tracing/zipkin/ZipkinConsumerDelegate.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vWmlwa2luQ29uc3VtZXJEZWxlZ2F0ZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...icecomb/tracing/zipkin/ZipkinProviderDelegate.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vWmlwa2luUHJvdmlkZXJEZWxlZ2F0ZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.86% <0.00%> (+1.08%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e45749...b17d710](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3011?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#issuecomment-1151818199
@liubao68 I think this PR can be merged, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#discussion_r884349736
##########
tracing/tracing-zipkin/src/test/java/org/apache/servicecomb/tracing/zipkin/ZipkinTracingAdviserTest.java:
##########
@@ -134,11 +146,11 @@ public void startsNewChildSpan() {
MatcherAssert.assertThat(traces.size(), is(nThreads));
- for (Queue<zipkin2.Span> queue : traces.values()) {
- zipkin2.Span child = queue.poll();
+ for (Queue<MutableSpan> queue : traces.values()) {
+ MutableSpan parent = queue.poll();
Review Comment:
Why change the `poll` order, is this change compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] HaitaoDeng commented on a diff in pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
HaitaoDeng commented on code in PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#discussion_r892277950
##########
tracing/tracing-zipkin/src/test/java/org/apache/servicecomb/tracing/zipkin/ZipkinTracingAdviserTest.java:
##########
@@ -134,11 +146,11 @@ public void startsNewChildSpan() {
MatcherAssert.assertThat(traces.size(), is(nThreads));
- for (Queue<zipkin2.Span> queue : traces.values()) {
- zipkin2.Span child = queue.poll();
+ for (Queue<MutableSpan> queue : traces.values()) {
+ MutableSpan parent = queue.poll();
Review Comment:
repaired,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] HaitaoDeng commented on pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
HaitaoDeng commented on PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#issuecomment-1151151393
>
OK
> Please use [code templates in etc](https://github.com/apache/servicecomb-java-chassis/tree/master/etc) folder to format code
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] tyluffy commented on pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
tyluffy commented on PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#issuecomment-1274170373
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] lovehzj commented on pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
lovehzj commented on PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#issuecomment-1140467818
I have bump okhttp3 version to 4.x. Could you please rebase the master code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9
Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#issuecomment-1150986212
Please use [code templates in etc](https://github.com/apache/servicecomb-java-chassis/tree/master/etc) folder to format code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org