[jira] [Comment Edited] (PHOENIX-2348) The value of DEFAULT_SPOOL_DIRECTORY is invalid on Windows

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116734#comment-15116734 ] 

James Taylor edited comment on PHOENIX-2348 at 1/26/16 5:43 AM:
----------------------------------------------------------------

Looks like your commit broke a number of unit tests, [~Dumindux]. It passed in the 1.0 branch, though. Would you mind trying the tests in the 0.98 branch locally? If it fails, then probably best to revert your change until we can understand why (or come up with a fix that works for all branches).


was (Author: jamestaylor):
Looks like your commit broke a number of unit tests, [~Dumindux]. Please revert and make sure you run the tests before committing.

> The value of DEFAULT_SPOOL_DIRECTORY is invalid on Windows
> ----------------------------------------------------------
>
>                 Key: PHOENIX-2348
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2348
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.5.2
>         Environment: windows
>            Reporter: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2348.patch
>
>
> The value of DEFAULT_SPOOL_DIRECTORY is the "/tmp", so the IOException will happen if we run the phoenix client on Windows.
> Does we should use the tmp path got from system property. For example:
> DEFAULT_SPOOL_DIRECTORY = System.getProperty("java.io.tmpdir");



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)