You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by Ovilia <ov...@gmail.com> on 2019/01/25 08:31:01 UTC

[VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

--------------------------
[Release Verion] 4.2.1-rc.1
[Release Commit] 9234f03
--------------------------
Subject:

[VOTE] Release Apache ECharts 4.2.1 (release candidate 1)


I am pleased to be calling this vote for the release of Apache ECharts
4.2.1 (release candidate 1).

The release candidate to be voted over is available at:
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/

The release candidate is signed with a GPG key available at:
https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS

The Git commit for this release is:
https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=9234f03

The Release Note is available in:
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/RELEASE_NOTE.txt

Some shell commands for validating the release:

```shell
# Download the release:
curl
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/apache-echarts-4.2.1-rc.1-incubating-src.zip
-o apache-echarts-4.2.1-rc.1-incubating-src.zip
unzip apache-echarts-4.2.1-rc.1-incubating-src.zip -d
apache-echarts-4.2.1-rc.1-incubating-src > /dev/null

# Build the project (Node.js environment is required):
cd "apache-echarts-4.2.1-rc.1-incubating-src" && npm install && cd ..
node "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --release
# (See help: `node
"apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --help`)
```


Please vote on releasing this package as:
Apache ECharts 4.2.1 (release candidate 1)
by "2019-01-28T09:24:32.402Z".

[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...

Anyone can participate in testing and voting, not just committers, please
feel free to try out the release candidate and provide your votes.

--------------------------

Zhang Wenli
http://zhangwenli.com

Re: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

Posted by Ovilia <ov...@gmail.com>.
This vote passes with 3 [+1] binding votes and no [0] or [-1] votes.

+1 binding: [3]
Shuang Su
Yi Shen
Deqing Li

Vote thread:
https://lists.apache.org/thread.html/30a097ec4cc086e91ee3dee2b6b10ae53da76fee7115dd263ea0120d@%3Cdev.echarts.apache.org%3E

I'll continue with the release process on general@ and the release
announcement will follow in the next few days.

Zhang Wenli
http://zhangwenli.com


On Tue, Jan 29, 2019 at 2:25 PM Deqing Li <an...@gmail.com> wrote:

> +1(binding)
>
> Yi Shen <sh...@gmail.com> 于2019年1月28日周一 上午10:46写道:
>
> > +1 (binding)
> >
> > Ovilia <ov...@gmail.com> 于2019年1月25日周五 下午4:33写道:
> >
> > > --------------------------
> > > [Release Verion] 4.2.1-rc.1
> > > [Release Commit] 9234f03
> > > --------------------------
> > > Subject:
> > >
> > > [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)
> > >
> > >
> > > I am pleased to be calling this vote for the release of Apache ECharts
> > > 4.2.1 (release candidate 1).
> > >
> > > The release candidate to be voted over is available at:
> > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/
> > >
> > > The release candidate is signed with a GPG key available at:
> > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
> > >
> > > The Git commit for this release is:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=9234f03
> > >
> > > The Release Note is available in:
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/RELEASE_NOTE.txt
> > >
> > > Some shell commands for validating the release:
> > >
> > > ```shell
> > > # Download the release:
> > > curl
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/apache-echarts-4.2.1-rc.1-incubating-src.zip
> > > -o apache-echarts-4.2.1-rc.1-incubating-src.zip
> > > unzip apache-echarts-4.2.1-rc.1-incubating-src.zip -d
> > > apache-echarts-4.2.1-rc.1-incubating-src > /dev/null
> > >
> > > # Build the project (Node.js environment is required):
> > > cd "apache-echarts-4.2.1-rc.1-incubating-src" && npm install && cd ..
> > > node "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js"
> --release
> > > # (See help: `node
> > > "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --help`)
> > > ```
> > >
> > >
> > > Please vote on releasing this package as:
> > > Apache ECharts 4.2.1 (release candidate 1)
> > > by "2019-01-28T09:24:32.402Z".
> > >
> > > [ ] +1 Release this package
> > > [ ] 0 I don't feel strongly about it, but don't object
> > > [ ] -1 Do not release this package because...
> > >
> > > Anyone can participate in testing and voting, not just committers,
> please
> > > feel free to try out the release candidate and provide your votes.
> > >
> > > --------------------------
> > >
> > > Zhang Wenli
> > > http://zhangwenli.com
> > >
> >
> >
> > --
> > Yi Shen
> > Senior Developer
> > Baidu, Inc.
> >
>

Re: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

Posted by Deqing Li <an...@gmail.com>.
+1(binding)

Yi Shen <sh...@gmail.com> 于2019年1月28日周一 上午10:46写道:

> +1 (binding)
>
> Ovilia <ov...@gmail.com> 于2019年1月25日周五 下午4:33写道:
>
> > --------------------------
> > [Release Verion] 4.2.1-rc.1
> > [Release Commit] 9234f03
> > --------------------------
> > Subject:
> >
> > [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)
> >
> >
> > I am pleased to be calling this vote for the release of Apache ECharts
> > 4.2.1 (release candidate 1).
> >
> > The release candidate to be voted over is available at:
> > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/
> >
> > The release candidate is signed with a GPG key available at:
> > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
> >
> > The Git commit for this release is:
> >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=9234f03
> >
> > The Release Note is available in:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/RELEASE_NOTE.txt
> >
> > Some shell commands for validating the release:
> >
> > ```shell
> > # Download the release:
> > curl
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/apache-echarts-4.2.1-rc.1-incubating-src.zip
> > -o apache-echarts-4.2.1-rc.1-incubating-src.zip
> > unzip apache-echarts-4.2.1-rc.1-incubating-src.zip -d
> > apache-echarts-4.2.1-rc.1-incubating-src > /dev/null
> >
> > # Build the project (Node.js environment is required):
> > cd "apache-echarts-4.2.1-rc.1-incubating-src" && npm install && cd ..
> > node "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --release
> > # (See help: `node
> > "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --help`)
> > ```
> >
> >
> > Please vote on releasing this package as:
> > Apache ECharts 4.2.1 (release candidate 1)
> > by "2019-01-28T09:24:32.402Z".
> >
> > [ ] +1 Release this package
> > [ ] 0 I don't feel strongly about it, but don't object
> > [ ] -1 Do not release this package because...
> >
> > Anyone can participate in testing and voting, not just committers, please
> > feel free to try out the release candidate and provide your votes.
> >
> > --------------------------
> >
> > Zhang Wenli
> > http://zhangwenli.com
> >
>
>
> --
> Yi Shen
> Senior Developer
> Baidu, Inc.
>

Re: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

Posted by Yi Shen <sh...@gmail.com>.
+1 (binding)

Ovilia <ov...@gmail.com> 于2019年1月25日周五 下午4:33写道:

> --------------------------
> [Release Verion] 4.2.1-rc.1
> [Release Commit] 9234f03
> --------------------------
> Subject:
>
> [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)
>
>
> I am pleased to be calling this vote for the release of Apache ECharts
> 4.2.1 (release candidate 1).
>
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/
>
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
>
> The Git commit for this release is:
>
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=9234f03
>
> The Release Note is available in:
>
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/RELEASE_NOTE.txt
>
> Some shell commands for validating the release:
>
> ```shell
> # Download the release:
> curl
>
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/apache-echarts-4.2.1-rc.1-incubating-src.zip
> -o apache-echarts-4.2.1-rc.1-incubating-src.zip
> unzip apache-echarts-4.2.1-rc.1-incubating-src.zip -d
> apache-echarts-4.2.1-rc.1-incubating-src > /dev/null
>
> # Build the project (Node.js environment is required):
> cd "apache-echarts-4.2.1-rc.1-incubating-src" && npm install && cd ..
> node "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --release
> # (See help: `node
> "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --help`)
> ```
>
>
> Please vote on releasing this package as:
> Apache ECharts 4.2.1 (release candidate 1)
> by "2019-01-28T09:24:32.402Z".
>
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
>
> Anyone can participate in testing and voting, not just committers, please
> feel free to try out the release candidate and provide your votes.
>
> --------------------------
>
> Zhang Wenli
> http://zhangwenli.com
>


-- 
Yi Shen
Senior Developer
Baidu, Inc.

Re: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

Posted by SHUANG SU <su...@gmail.com>.
+1 (binding)

I checked:
✔️ Incubating in name.
✔️ sha512 and asc is correct.
✔️ Download and npm install and build OK.
✔️ The source code is the same as the GitHub tag "4.2.1-rc.1".
✔️ DISCLAIMER exists.
✔️ LICENSE is correct.
✔️ RELEASE_NOTE exists and correct.


The scripts used for the checking:

```shell
export ECHARTS_NEW_VERSION="4.2.1-rc.1"
export ECHARTS_ARTEFACT_NAME="apache-echarts-${ECHARTS_NEW_VERSION}
-incubating-src.zip"
export ECHARTS_ARTEFACT_DIR="apache-echarts-${ECHARTS_NEW_VERSION}
-incubating-src"
export ECHARTS_DEV_SVN="
https://dist.apache.org/repos/dist/dev/incubator/echarts"
export ECHARTS_RELEASE_SVN="
https://dist.apache.org/repos/dist/release/incubator/echarts"
export TMP_PATH="/sushuangwork/met/act/gitall/tmp/xxx"

# Download
cd ${TMP_PATH}
curl https://dist.apache.org/repos/dist/dev/incubator/echarts/
${ECHARTS_NEW_VERSION}/${ECHARTS_ARTEFACT_NAME} -o ${ECHARTS_ARTEFACT_NAME}
unzip ${ECHARTS_ARTEFACT_NAME} -d ${ECHARTS_ARTEFACT_DIR} > /dev/null

# Build
cd ${TMP_PATH}/${ECHARTS_ARTEFACT_DIR}
npm i
node build/build.js --release

# Check License
java -jar "${ECHARTS_BASE}/asf-tool/rat/apache-rat-0.12.jar" ${TMP_PATH}/
${ECHARTS_ARTEFACT_DIR} > 111
vim 111 # Check

# Check sha512
curl https://dist.apache.org/repos/dist/dev/incubator/echarts/
${ECHARTS_NEW_VERSION}/${ECHARTS_ARTEFACT_NAME}.sha512 -o
${ECHARTS_ARTEFACT_NAME}.sha512
gpg --print-md SHA512 ${ECHARTS_ARTEFACT_NAME} > ${ECHARTS_ARTEFACT_NAME}
-local.sha512
diff ${ECHARTS_ARTEFACT_NAME}.sha512 ${ECHARTS_ARTEFACT_NAME}-local.sha512 #
Should output nothing

# Check asc
curl https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS -o KEYS
curl https://dist.apache.org/repos/dist/dev/incubator/echarts/
${ECHARTS_NEW_VERSION}/${ECHARTS_ARTEFACT_NAME}.asc -o
${ECHARTS_ARTEFACT_NAME}.asc
gpg --import KEYS
gpg --verify ${ECHARTS_ARTEFACT_NAME}.asc # Check

# Check the released source code is the same as the GitHub tag.
cd ${TMP_PATH}
rm -rf ${TMP_PATH}/ec-git
git clone -b '4.2.1-rc1' --single-branch --depth 1
https://github.com/apache/incubator-echarts.git ec-git
diff -r ${TMP_PATH}/ec-git
${TMP_PATH}/apache-echarts-${ECHARTS_NEW_VERSION}-incubating-src
# Check
```

------------------------------
 Su Shuang (100pah)
------------------------------



On Fri, 25 Jan 2019 at 16:33, Ovilia <ov...@gmail.com> wrote:

> --------------------------
> [Release Verion] 4.2.1-rc.1
> [Release Commit] 9234f03
> --------------------------
> Subject:
>
> [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)
>
>
> I am pleased to be calling this vote for the release of Apache ECharts
> 4.2.1 (release candidate 1).
>
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/
>
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
>
> The Git commit for this release is:
>
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=9234f03
>
> The Release Note is available in:
>
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/RELEASE_NOTE.txt
>
> Some shell commands for validating the release:
>
> ```shell
> # Download the release:
> curl
>
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.2.1-rc.1/apache-echarts-4.2.1-rc.1-incubating-src.zip
> -o apache-echarts-4.2.1-rc.1-incubating-src.zip
> unzip apache-echarts-4.2.1-rc.1-incubating-src.zip -d
> apache-echarts-4.2.1-rc.1-incubating-src > /dev/null
>
> # Build the project (Node.js environment is required):
> cd "apache-echarts-4.2.1-rc.1-incubating-src" && npm install && cd ..
> node "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --release
> # (See help: `node
> "apache-echarts-4.2.1-rc.1-incubating-src/build/build.js" --help`)
> ```
>
>
> Please vote on releasing this package as:
> Apache ECharts 4.2.1 (release candidate 1)
> by "2019-01-28T09:24:32.402Z".
>
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
>
> Anyone can participate in testing and voting, not just committers, please
> feel free to try out the release candidate and provide your votes.
>
> --------------------------
>
> Zhang Wenli
> http://zhangwenli.com
>