You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jamesandersen <gi...@git.apache.org> on 2016/01/15 03:03:57 UTC
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
GitHub user jamesandersen opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3
CB-10269: Replace cordova exec only when present in wkwebview
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jamesandersen/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 66d70fed2454b1af164214a06a91cbeec7065cb0
Author: James Andersen <ja...@universalmind.com>
Date: 2016-01-15T02:02:42Z
CB-10269: Replace cordova exec only when present in wkwebview
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by andres-torres-marroquin <gi...@git.apache.org>.
Github user andres-torres-marroquin commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179887523
I also thought it wasn't merged, how can we know that? I'm unfamiliar on how this is handled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179554784
It has already been merged in https://github.com/apache/cordova-plugin-wkwebview-engine/commit/faa9d877045d8baf8afdfd0d8689389ec240e2e4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180132192
This is part of an Apache Software Froundation project, so any release needs to follow the ASF guidelines including a 48-hour voting period with 3 votes of approval on the mailing list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by hassankhan <gi...@git.apache.org>.
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179556132
Is it possible for a new release to be tagged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by hassankhan <gi...@git.apache.org>.
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179555817
Ah my mistake, I assumed the error I was getting was related to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by IvanKarpan <gi...@git.apache.org>.
Github user IvanKarpan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180050118
IMHO without a release to npm this whole WKWebView support of Cordova is pretty not usable at all ATM...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by jamesandersen <gi...@git.apache.org>.
Github user jamesandersen closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by hassankhan <gi...@git.apache.org>.
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180128975
True, but a new release is usually only an `npm publish` away, unless I'm mistaken? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179891115
check the jira issue
https://issues.apache.org/jira/browse/CB-10269
Commit faa9d877045d8baf8afdfd0d8689389ec240e2e4 in cordova-plugin-wkwebview-engine's branch refs/heads/master from James Andersen
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=faa9d87 ]
Or check the main page https://github.com/apache/cordova-plugin-wkwebview-engine, you can see.
jamesandersen committed with shazron CB-10269: Replace cordova exec only when present in wkwebview
It should have closed this, but sometimes fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by hassankhan <gi...@git.apache.org>.
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179944762
I believe it is merged just fine, but there hasn't been a new release of the plugin on npm, so anybody trying to use the latest version won't get this fix at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180077007
It's not on NPM yet, plugin releases take time.
Anybody using cordova can install from github, they don't have to wait for the NPM release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-194040883
@jamesandersen can you close this? it came out in the 1.0.2 release of the plugin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...
Posted by hassankhan <gi...@git.apache.org>.
Github user hassankhan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179554625
+1 can this be merged soon please? :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org