You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by alexandremattje <gi...@git.apache.org> on 2014/05/15 18:49:58 UTC

[GitHub] thrift pull request: Firemonkey

GitHub user alexandremattje opened a pull request:

    https://github.com/apache/thrift/pull/121

    Firemonkey

    I create lib/delphi-firemonkey folder with source code to compile in delphi-firemonkey applications, for mobile application.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alexandremattje/thrift firemonkey

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit b515cd6310f035e8bf6cdf5398101abda969cb7b
Author: Alexandre Mattje <am...@gmail.com>
Date:   2014-04-17T17:56:18Z

    "const events: IProcessorEvents = nil" missing param on IProcessor implementation

commit d90ec449a05cd798db6fa0e72eccd77bfdd3fc42
Author: Alexandre Mattje <am...@gmail.com>
Date:   2014-04-17T18:01:17Z

    type cast TBytes > TIdBytes and TIdBytes > TBytes

commit e433348cd01db4c17cdb4f59d7cecc5b17ec9709
Author: Alexandre Mattje <am...@gmail.com>
Date:   2014-05-11T03:49:10Z

    using TIdClientHttp and TIdServerHttp

commit c5dd0cddac6ad70d13f75959d368fd38659b5332
Author: Alexandre Mattje <am...@gmail.com>
Date:   2014-05-12T15:50:07Z

    delphi-firemonkey

commit f7ae597fb9963a4caf85bb10e4814558d7e6d25c
Author: Alexandre Mattje <am...@gmail.com>
Date:   2014-05-12T15:53:27Z

    Revert ""const events: IProcessorEvents = nil" missing param on IProcessor implementation"
    
    This reverts commit b515cd6310f035e8bf6cdf5398101abda969cb7b.

commit fb9a54577a5471874b62b71fcfc9015f20bff44f
Author: Alexandre Mattje <am...@gmail.com>
Date:   2014-05-15T16:45:40Z

    merge from master

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Firemonkey

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/121#issuecomment-43379870
  
    Great! 
    
    Could you please create a [JIRA](https://issues.apache.org/jira/browse/THRIFT) ticket and have a look at the [contrib guide](http://thrift.apache.org/docs/HowToContribute), just to make sure everything is in place? 
    
    Looking forward to review it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Firemonkey

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/121#issuecomment-43380754
  
    Why are you reformatting the whole code? No wonder the patch is that big.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Firemonkey

Posted by alexandremattje <gi...@git.apache.org>.
Github user alexandremattje closed the pull request at:

    https://github.com/apache/thrift/pull/121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---