You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/07 06:59:42 UTC

[GitHub] markusthoemmes commented on issue #3507: allow use of string for controller id

markusthoemmes commented on issue #3507: allow use of string for controller id
URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-395314428
 
 
   Existential question: Should we have `ControllerInstanceId` and `InvokerInstanceId`? I think with landing the TransactionId header support and the cluster bootstrap support, the controller id can indeed be just a `String`.
   
   However, while we are on the current loadbalancer, the `InvokerInstanceId` will need to be an `Int`.
   
   I think, having a distinct type for each of them will also greatly improve code readability, because then you know from the method's signature which instance we have at hand.
   
   Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services