You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/16 15:40:15 UTC
[GitHub] [airflow] ashb opened a new pull request #7432: [AIRFLOW-6818]
Prevent Docker cache-busting when editing www/templates
ashb opened a new pull request #7432: [AIRFLOW-6818] Prevent Docker cache-busting when editing www/templates
URL: https://github.com/apache/airflow/pull/7432
There is two parts to this PR:
1. Only copying www/webpack.config.js and www/static/ before running the
asset pipeline
2. Making sure that _all_ files (not just the critical ones) have the
same permissions.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7432: [AIRFLOW-6818] Prevent
Docker cache-busting when editing www/templates
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7432: [AIRFLOW-6818] Prevent Docker cache-busting when editing www/templates
URL: https://github.com/apache/airflow/pull/7432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7432: [AIRFLOW-6818] Prevent
Docker cache-busting when editing www/templates
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7432: [AIRFLOW-6818] Prevent Docker cache-busting when editing www/templates
URL: https://github.com/apache/airflow/pull/7432#issuecomment-586728347
Green light frrom me :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7432: [AIRFLOW-6818] Prevent
Docker cache-busting when editing www/templates
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7432: [AIRFLOW-6818] Prevent Docker cache-busting when editing www/templates
URL: https://github.com/apache/airflow/pull/7432#issuecomment-586720626
Fully green build this time https://travis-ci.com/ashb/airflow/builds/149165957
The previous (now reverted) PR was failing because of the permissions on scripts/ci/mysql/conf.d which was missing `a+x` -- I have fixed that in this PR to give +x on all directiroes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services