You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/05 19:46:55 UTC
Review Request 31769: Fixed flaky
MasterTest.ShutdownFrameworkWhileTaskRunning test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31769/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Bugs: MESOS-2401
https://issues.apache.org/jira/browse/MESOS-2401
Repository: mesos
Description
-------
Removed the setting of executor grace shutdown to "0s" to give a chance for the executor to actually get the shutdown signal.
Diffs
-----
src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
Diff: https://reviews.apache.org/r/31769/diff/
Testing
-------
make check GTEST_FILTER="*ShutdownFrameworkWhileTaskRunning*" GTEST_REPEAT=1000 MESOS_VERBOSE=1 GTEST_BREAK_ON_FAILURE=1
Thanks,
Vinod Kone
Re: Review Request 31769: Fixed flaky
MasterTest.ShutdownFrameworkWhileTaskRunning test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31769/#review75422
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31769]
All tests passed.
- Mesos ReviewBot
On March 5, 2015, 6:46 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31769/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 6:46 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-2401
> https://issues.apache.org/jira/browse/MESOS-2401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the setting of executor grace shutdown to "0s" to give a chance for the executor to actually get the shutdown signal.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
>
> Diff: https://reviews.apache.org/r/31769/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*ShutdownFrameworkWhileTaskRunning*" GTEST_REPEAT=1000 MESOS_VERBOSE=1 GTEST_BREAK_ON_FAILURE=1
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 31769: Fixed flaky
MasterTest.ShutdownFrameworkWhileTaskRunning test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31769/#review75541
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 5, 2015, 6:46 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31769/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 6:46 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-2401
> https://issues.apache.org/jira/browse/MESOS-2401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the setting of executor grace shutdown to "0s" to give a chance for the executor to actually get the shutdown signal.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 580e1f818201f951c11e4e652a7941fcd888356d
>
> Diff: https://reviews.apache.org/r/31769/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*ShutdownFrameworkWhileTaskRunning*" GTEST_REPEAT=1000 MESOS_VERBOSE=1 GTEST_BREAK_ON_FAILURE=1
>
>
> Thanks,
>
> Vinod Kone
>
>