You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/04/20 15:15:16 UTC

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r183083335
  
    --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java ---
    @@ -182,7 +182,7 @@ private String getQueryString(Expression expression) {
         // execute index search
         TopDocs result;
         try {
    -      result = indexSearcher.search(query, indexReader.maxDoc());
    +      result = indexSearcher.search(query, Integer.MAX_VALUE);
    --- End diff --
    
    I think it is better to pass this variable from the TEXT_MATCH UDF, like TEXT_MATCH("name:a", 100), so that user can decide the value. If user does not give the value, default value can be Integer.MAX_VALUE


---