You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/20 14:02:17 UTC

[GitHub] [ignite-3] tledkov-gridgain commented on a change in pull request #403: IGNITE-15600 Cache for Calcite SQL plans in 3.0

tledkov-gridgain commented on a change in pull request #403:
URL: https://github.com/apache/ignite-3/pull/403#discussion_r732810672



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/SqlQueryProcessor.java
##########
@@ -78,12 +82,14 @@ public SqlQueryProcessor(
             taskExecutor
         );
 
-        SchemaHolderImpl schemaHolder = new SchemaHolderImpl();
+        QueryPlanCache cache = new QueryPlanCacheImpl(PLAN_CACHE_SIZE);

Review comment:
       The `QueryPlanCache` is created by the SqlQueryProcessor. Should the SqlQueryProcessor be owner of the query plan cache and manage the lifecycle of one?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org