You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by GitBox <gi...@apache.org> on 2026/07/10 21:35:07 UTC

[GH] (grails-core/fix/sitemesh3-viewresolver-definition-wrap): Workflow run "Coverage" failed!

The GitHub Actions job "Coverage" on grails-core.git/fix/sitemesh3-viewresolver-definition-wrap has failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
ccbc50c6c7a3cbd74856fe2eb7e59fdd4c4e93bb / Scott Murphy Heiberg <sc...@alwaysvip.com>
Implement the definition wrap as upstream's bean-definition mode

Sitemesh3ViewResolverDefinitionPostProcessor now extends upstream's
SiteMeshViewResolverPostProcessor - the class behind
sitemesh.viewResolver.wrapMode=bean-definition - and is registered under
upstream's bean name, so upstream's own @ConditionalOnMissingBean guard
defers to it. Together with the bean post-processor (which preempts the
wrap-all and bean-instance registrations by type), every upstream wrap
mode is covered by a Grails-flavoured implementation and the zero-wrap
startup warning cannot arise from a dangling mode.

The Grails implementation deliberately diverges from upstream on one
point: upstream re-registers the unwrapped resolver as a separate named
bean that stays visible to getBeansOfType sweeps - the same exposure
this PR closes - so the original definition is embedded as an anonymous
inner-bean definition instead. The wrapper definition now also honours
the inherited dispatchMode and includeErrorPages settings.

Report URL: https://github.com/apache/grails-core/actions/runs/29123742217

With regards,
GitHub Actions via GitBox