You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Matthew Marum (JIRA)" <ji...@apache.org> on 2011/01/25 20:59:45 UTC

[jira] Created: (SHINDIG-1492) View level support for Features and Locales

View level support for Features and Locales 
--------------------------------------------

                 Key: SHINDIG-1492
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
             Project: Shindig
          Issue Type: Improvement
    Affects Versions: 3.0.0
            Reporter: Matthew Marum
             Fix For: 3.0.0


Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.

http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal

Patch includes updated JUnit tests and new EndToEnd test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] [Commented] (SHINDIG-1492) View level support for Features and Locales

Posted by Matthew G Marum <mg...@us.ibm.com>.
Thanks Ziv!  I'll fix the test and repost patch.

Matt


|------------>
| From:      |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |Ziv Horesh <zh...@gmail.com>                                                                                                                    |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To:        |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |dev@shindig.apache.org                                                                                                                            |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date:      |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |04/01/2011 01:50 PM                                                                                                                               |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject:   |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |Re: [jira] [Commented] (SHINDIG-1492) View level support for Features and Locales                                                                 |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|





I had same problem. It is due to test depend on the order of a set to list
conversion, I just changed ("foo", "core") to ("core", "foo") to move
forward, but probably we should improve the test.


On Fri, Apr 1, 2011 at 10:29 AM, Paul Lindner (JIRA)
<ji...@apache.org>wrote:

>
>    [
>
https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014758#comment-13014758
]
>
> Paul Lindner commented on SHINDIG-1492:
> ---------------------------------------
>
> still failing for me on mac and linux, jdk 1.6  I think you just need to
> adjust your mocks for some other code that changed underneath you..
>
>
> > View level support for Features and Locales
> > --------------------------------------------
> >
> >                 Key: SHINDIG-1492
> >                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
> >             Project: Shindig
> >          Issue Type: Improvement
> >          Components: Java
> >    Affects Versions: 3.0.0
> >            Reporter: Matthew Marum
> >             Fix For: 3.0.0
> >
> >         Attachments: issue4077043_90002.diff
> >
> >
> > Patch to support View level features and locales which is an approved
> proposal for OpenSocial 2.0.
> > http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> > Patch includes updated JUnit tests and new EndToEnd test.
> > http://codereview.appspot.com/4077043/
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>


Re: [jira] [Commented] (SHINDIG-1492) View level support for Features and Locales

Posted by Ziv Horesh <zh...@gmail.com>.
I had same problem. It is due to test depend on the order of a set to list
conversion, I just changed ("foo", "core") to ("core", "foo") to move
forward, but probably we should improve the test.


On Fri, Apr 1, 2011 at 10:29 AM, Paul Lindner (JIRA) <ji...@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014758#comment-13014758]
>
> Paul Lindner commented on SHINDIG-1492:
> ---------------------------------------
>
> still failing for me on mac and linux, jdk 1.6  I think you just need to
> adjust your mocks for some other code that changed underneath you..
>
>
> > View level support for Features and Locales
> > --------------------------------------------
> >
> >                 Key: SHINDIG-1492
> >                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
> >             Project: Shindig
> >          Issue Type: Improvement
> >          Components: Java
> >    Affects Versions: 3.0.0
> >            Reporter: Matthew Marum
> >             Fix For: 3.0.0
> >
> >         Attachments: issue4077043_90002.diff
> >
> >
> > Patch to support View level features and locales which is an approved
> proposal for OpenSocial 2.0.
> > http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> > Patch includes updated JUnit tests and new EndToEnd test.
> > http://codereview.appspot.com/4077043/
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

[jira] Updated: (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment: viewLevelFeaturesShindig.patch

Patch for View level features/locales

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014555#comment-13014555 ] 

Matthew Marum commented on SHINDIG-1492:
----------------------------------------

Unfortunately no, all the test pass in my environment.  Those "getFeatureResources" calls are setup in the expectFeatureCalls method of that test.

Are you taking the latest patch set from the code review tool or the one from here?  The one attached here is old.  I'll update it just in case.

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1492) View level support for Features and Locales

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014758#comment-13014758 ] 

Paul Lindner commented on SHINDIG-1492:
---------------------------------------

still failing for me on mac and linux, jdk 1.6  I think you just need to adjust your mocks for some other code that changed underneath you..


> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: issue4077043_90002.diff
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Component/s: Java

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment:     (was: viewLevelFeaturesShindig.patch)

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment: issue4077043_90002.diff

Latest patch from http://codereview.appspot.com/4077043/

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: issue4077043_90002.diff
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment:     (was: viewLevelFeaturesShindig.patch)

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment:     (was: issue4077043_90002.diff)

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewlevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment: viewlevelFeaturesShindig.patch

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewlevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Attachment: viewLevelFeaturesShindig.patch

Updated patch to fix some code formatting.

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Marum updated SHINDIG-1492:
-----------------------------------

    Description: 
Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.

http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal

Patch includes updated JUnit tests and new EndToEnd test.

http://codereview.appspot.com/4077043/

  was:
Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.

http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal

Patch includes updated JUnit tests and new EndToEnd test.


> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SHINDIG-1492) View level support for Features and Locales

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1492.
-----------------------------------

    Resolution: Fixed

patch applied.  Thanks!

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewlevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (SHINDIG-1492) View level support for Features and Locales

Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner closed SHINDIG-1492.
---------------------------------


part of 2.5.0-beta1 release.

                
> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.5.0-beta1
>            Reporter: Matthew Marum
>             Fix For: 2.5.0-beta1
>
>         Attachments: viewlevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014937#comment-13014937 ] 

Matthew Marum commented on SHINDIG-1492:
----------------------------------------

I've made some changes, tests now pass on IBM and Sun 1.6 JREs.

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: issue4077043_90002.diff
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1492) View level support for Features and Locales

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014418#comment-13014418 ] 

Paul Lindner commented on SHINDIG-1492:
---------------------------------------

Any ideas about these test failures when I apply this patch?

Tests in error: 
  unsupportedFeatureThrows(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest): Unexpected exception, expected<org.apache.shindig.gadgets.rewrite.RewritingException> but was<java.lang.AssertionError>
  unsupportedViewFeatureThrows(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest): Unexpected exception, expected<org.apache.shindig.gadgets.rewrite.RewritingException> but was<java.lang.AssertionError>

----

Caused by: java.lang.AssertionError:
  Unexpected method call getFeatureResources(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@4ded4d06, [core, foo], []):
    getFeatureResources(same(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@4ded4d06), [foo, core], []): expected: 1, actual: 0
        at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:45)
        at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:73)
        at org.easymock.internal.ClassProxyFactory$MockMethodInterceptor.intercept(ClassProxyFactory


Caused by: java.lang.AssertionError:
  Unexpected method call getFeatureResources(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@770fba26, [core, foo], []):
    getFeatureResources(same(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@770fba26), [foo, core], []): expected: 1, actual: 0
        at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:45)
        at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:73)
        at org.easymock.internal.ClassProxyFactory$MockMethodInterceptor.intercept(ClassProxyFactory.java:92)
        at org.apache.shindig.gadgets.features.FeatureRegistry$$EnhancerByCGLIB$$f7357840.getFeatureResources(<generated>)


> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.
> http://codereview.appspot.com/4077043/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (SHINDIG-1492) View level support for Features and Locales

Posted by "Matthew Marum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986668#action_12986668 ] 

Matthew Marum commented on SHINDIG-1492:
----------------------------------------

Patch code review on appspot.

http://codereview.appspot.com/4077043/

> View level support for Features and Locales 
> --------------------------------------------
>
>                 Key: SHINDIG-1492
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1492
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Matthew Marum
>             Fix For: 3.0.0
>
>         Attachments: viewLevelFeaturesShindig.patch
>
>
> Patch to support View level features and locales which is an approved proposal for OpenSocial 2.0.
> http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
> Patch includes updated JUnit tests and new EndToEnd test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.