You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tapestry.apache.org by "Joost Schouten (ml)" <jo...@jsportal.com> on 2011/03/16 09:02:05 UTC
Missing Asset causes Exception where 404 would be more appropriate
Hi,
I have a bunch of robots crawling my assets folder and trying all sorts of requests to see if they can find holes in my app (example at [1]). Since the assets don't exist I get the following exception [2]. Would it not make more sence in this case to just return a 404 in stead? Would keep my error logs a lot cleaner :)
I am sure I can achieve this by decorating a service but maybe people agree that this could be part of the core? Any thoughts?
Cheers,
Joost
[1]:http://www.yanomo.com/assets/1.0.17/stack/en/application/x-www-form-urlencoded
[2]:
java.lang.RuntimeException: Invalid path for a stack asset request.
at org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.assembleStackContent(StackAssetRequestHandler.java:156)
at org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getUncompressedStream(StackAssetRequestHandler.java:144)
at org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getCompressedStream(StackAssetRequestHandler.java:130)
at org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getStream(StackAssetRequestHandler.java:121)
at org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.handleAssetRequest(StackAssetRequestHandler.java:84)
at org.apache.tapestry5.internal.services.AssetDispatcher.dispatch(AssetDispatcher.java:80)
at $Dispatcher_12eb55c013f.dispatch($Dispatcher_12eb55c013f.java)
at $Dispatcher_12eb55c0146.dispatch($Dispatcher_12eb55c0146.java)
at $Dispatcher_12eb55c0137.dispatch($Dispatcher_12eb55c0137.java)
at org.apache.tapestry5.services.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:321)
at org.apache.tapestry5.internal.services.RequestErrorFilter.service(RequestErrorFilter.java:26)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at org.apache.tapestry5.services.TapestryModule$4.service(TapestryModule.java:984)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at org.apache.tapestry5.services.TapestryModule$3.service(TapestryModule.java:974)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at org.apache.tapestry5.internal.services.StaticFilesFilter.service(StaticFilesFilter.java:90)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at com.joostschouten.common.http.tapestrybase.services.TransactionFilter.service(TransactionFilter.java:91)
at $RequestFilter_12eb55c0132.service($RequestFilter_12eb55c0132.java)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at com.joostschouten.common.http.tapestrybase.services.PersistLocaleRequestFilter.service(PersistLocaleRequestFilter.java:53)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at org.apache.tapestry5.internal.services.CheckForUpdatesFilter$2.invoke(CheckForUpdatesFilter.java:90)
at org.apache.tapestry5.internal.services.CheckForUpdatesFilter$2.invoke(CheckForUpdatesFilter.java:80)
at org.apache.tapestry5.ioc.internal.util.ConcurrentBarrier.withRead(ConcurrentBarrier.java:85)
at org.apache.tapestry5.internal.services.CheckForUpdatesFilter.service(CheckForUpdatesFilter.java:103)
at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
at $RequestHandler_12eb55c012c.service($RequestHandler_12eb55c012c.java)
at org.apache.tapestry5.services.TapestryModule$HttpServletRequestHandlerTerminator.service(TapestryModule.java:272)
at
org.apache.tapestry5.upload.internal.services.MultipartServletRequestFilter.service(MultipartServletRequestFilter.java:44)
at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
at org.apache.tapestry5.internal.gzip.GZipFilter.service(GZipFilter.java:53)
at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
at org.apache.tapestry5.internal.services.IgnoredPathsFilter.service(IgnoredPathsFilter.java:62)
at $HttpServletRequestFilter_12eb55c012a.service($HttpServletRequestFilter_12eb55c012a.java)
at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
at org.apache.tapestry5.services.TapestryModule$2.service(TapestryModule.java:928)
at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
at $HttpServletRequestHandler_12eb55c0128.service($HttpServletRequestHandler_12eb55c0128.java)
at org.apache.tapestry5.TapestryFilter.doFilter(TapestryFilter.java:147)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:164)
at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:141)
at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:90)
at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:417)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
at java.lang.Thread.run(Thread.java:619)
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: Missing Asset causes Exception where 404 would be more appropriate
Posted by "Joost Schouten (ml)" <jo...@jsportal.com>.
On 16/03/11 10:58 AM, Ulrich Stärk wrote:
> Indeed. We should handle stack assets the same as context and classpath assets where we DO issue a
> 404 not found. Please file an issue.
>
> Uli
Ah! Didn't even know we already did do 404's on the other assets. Issue
filed at: https://issues.apache.org/jira/browse/TAP5-1477
Cheers,
Joost
> On 16.03.2011 09:02, Joost Schouten (ml) wrote:
>>
>> Hi,
>>
>> I have a bunch of robots crawling my assets folder and trying all sorts of requests to see if they
>> can find holes in my app (example at [1]). Since the assets don't exist I get the following
>> exception [2]. Would it not make more sence in this case to just return a 404 in stead? Would keep
>> my error logs a lot cleaner :)
>>
>> I am sure I can achieve this by decorating a service but maybe people agree that this could be part
>> of the core? Any thoughts?
>>
>> Cheers,
>> Joost
>>
>> [1]:http://www.yanomo.com/assets/1.0.17/stack/en/application/x-www-form-urlencoded
>>
>> [2]:
>> java.lang.RuntimeException: Invalid path for a stack asset request.
>> at
>> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.assembleStackContent(StackAssetRequestHandler.java:156)
>>
>> at
>> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getUncompressedStream(StackAssetRequestHandler.java:144)
>>
>> at
>> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getCompressedStream(StackAssetRequestHandler.java:130)
>>
>> at
>> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getStream(StackAssetRequestHandler.java:121)
>>
>> at
>> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.handleAssetRequest(StackAssetRequestHandler.java:84)
>>
>> at org.apache.tapestry5.internal.services.AssetDispatcher.dispatch(AssetDispatcher.java:80)
>> at $Dispatcher_12eb55c013f.dispatch($Dispatcher_12eb55c013f.java)
>> at $Dispatcher_12eb55c0146.dispatch($Dispatcher_12eb55c0146.java)
>> at $Dispatcher_12eb55c0137.dispatch($Dispatcher_12eb55c0137.java)
>> at
>> org.apache.tapestry5.services.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:321)
>> at org.apache.tapestry5.internal.services.RequestErrorFilter.service(RequestErrorFilter.java:26)
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at org.apache.tapestry5.services.TapestryModule$4.service(TapestryModule.java:984)
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at org.apache.tapestry5.services.TapestryModule$3.service(TapestryModule.java:974)
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at org.apache.tapestry5.internal.services.StaticFilesFilter.service(StaticFilesFilter.java:90)
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at
>> com.joostschouten.common.http.tapestrybase.services.TransactionFilter.service(TransactionFilter.java:91)
>>
>> at $RequestFilter_12eb55c0132.service($RequestFilter_12eb55c0132.java)
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at
>> com.joostschouten.common.http.tapestrybase.services.PersistLocaleRequestFilter.service(PersistLocaleRequestFilter.java:53)
>>
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at
>> org.apache.tapestry5.internal.services.CheckForUpdatesFilter$2.invoke(CheckForUpdatesFilter.java:90)
>> at
>> org.apache.tapestry5.internal.services.CheckForUpdatesFilter$2.invoke(CheckForUpdatesFilter.java:80)
>> at org.apache.tapestry5.ioc.internal.util.ConcurrentBarrier.withRead(ConcurrentBarrier.java:85)
>> at
>> org.apache.tapestry5.internal.services.CheckForUpdatesFilter.service(CheckForUpdatesFilter.java:103)
>> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
>> at $RequestHandler_12eb55c012c.service($RequestHandler_12eb55c012c.java)
>> at
>> org.apache.tapestry5.services.TapestryModule$HttpServletRequestHandlerTerminator.service(TapestryModule.java:272)
>>
>> at
>> org.apache.tapestry5.upload.internal.services.MultipartServletRequestFilter.service(MultipartServletRequestFilter.java:44)
>>
>> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
>> at org.apache.tapestry5.internal.gzip.GZipFilter.service(GZipFilter.java:53)
>> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
>> at org.apache.tapestry5.internal.services.IgnoredPathsFilter.service(IgnoredPathsFilter.java:62)
>> at $HttpServletRequestFilter_12eb55c012a.service($HttpServletRequestFilter_12eb55c012a.java)
>> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
>> at org.apache.tapestry5.services.TapestryModule$2.service(TapestryModule.java:928)
>> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
>> at $HttpServletRequestHandler_12eb55c0128.service($HttpServletRequestHandler_12eb55c0128.java)
>> at org.apache.tapestry5.TapestryFilter.doFilter(TapestryFilter.java:147)
>> at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>> at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:164)
>> at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:141)
>> at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:90)
>> at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:417)
>> at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
>> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
>> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
>> at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
>> at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
>> at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
>> at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
>> at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
>> at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
>> at java.lang.Thread.run(Thread.java:619)
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: users-help@tapestry.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: Missing Asset causes Exception where 404 would be more appropriate
Posted by Ulrich Stärk <ul...@spielviel.de>.
Indeed. We should handle stack assets the same as context and classpath assets where we DO issue a
404 not found. Please file an issue.
Uli
On 16.03.2011 09:02, Joost Schouten (ml) wrote:
>
>
> Hi,
>
> I have a bunch of robots crawling my assets folder and trying all sorts of requests to see if they
> can find holes in my app (example at [1]). Since the assets don't exist I get the following
> exception [2]. Would it not make more sence in this case to just return a 404 in stead? Would keep
> my error logs a lot cleaner :)
>
> I am sure I can achieve this by decorating a service but maybe people agree that this could be part
> of the core? Any thoughts?
>
> Cheers,
> Joost
>
> [1]:http://www.yanomo.com/assets/1.0.17/stack/en/application/x-www-form-urlencoded
>
> [2]:
> java.lang.RuntimeException: Invalid path for a stack asset request.
> at
> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.assembleStackContent(StackAssetRequestHandler.java:156)
>
> at
> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getUncompressedStream(StackAssetRequestHandler.java:144)
>
> at
> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getCompressedStream(StackAssetRequestHandler.java:130)
>
> at
> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getStream(StackAssetRequestHandler.java:121)
>
> at
> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.handleAssetRequest(StackAssetRequestHandler.java:84)
>
> at org.apache.tapestry5.internal.services.AssetDispatcher.dispatch(AssetDispatcher.java:80)
> at $Dispatcher_12eb55c013f.dispatch($Dispatcher_12eb55c013f.java)
> at $Dispatcher_12eb55c0146.dispatch($Dispatcher_12eb55c0146.java)
> at $Dispatcher_12eb55c0137.dispatch($Dispatcher_12eb55c0137.java)
> at
> org.apache.tapestry5.services.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:321)
> at org.apache.tapestry5.internal.services.RequestErrorFilter.service(RequestErrorFilter.java:26)
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at org.apache.tapestry5.services.TapestryModule$4.service(TapestryModule.java:984)
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at org.apache.tapestry5.services.TapestryModule$3.service(TapestryModule.java:974)
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at org.apache.tapestry5.internal.services.StaticFilesFilter.service(StaticFilesFilter.java:90)
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at
> com.joostschouten.common.http.tapestrybase.services.TransactionFilter.service(TransactionFilter.java:91)
>
> at $RequestFilter_12eb55c0132.service($RequestFilter_12eb55c0132.java)
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at
> com.joostschouten.common.http.tapestrybase.services.PersistLocaleRequestFilter.service(PersistLocaleRequestFilter.java:53)
>
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at
> org.apache.tapestry5.internal.services.CheckForUpdatesFilter$2.invoke(CheckForUpdatesFilter.java:90)
> at
> org.apache.tapestry5.internal.services.CheckForUpdatesFilter$2.invoke(CheckForUpdatesFilter.java:80)
> at org.apache.tapestry5.ioc.internal.util.ConcurrentBarrier.withRead(ConcurrentBarrier.java:85)
> at
> org.apache.tapestry5.internal.services.CheckForUpdatesFilter.service(CheckForUpdatesFilter.java:103)
> at $RequestHandler_12eb55c0138.service($RequestHandler_12eb55c0138.java)
> at $RequestHandler_12eb55c012c.service($RequestHandler_12eb55c012c.java)
> at
> org.apache.tapestry5.services.TapestryModule$HttpServletRequestHandlerTerminator.service(TapestryModule.java:272)
>
> at
> org.apache.tapestry5.upload.internal.services.MultipartServletRequestFilter.service(MultipartServletRequestFilter.java:44)
>
> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
> at org.apache.tapestry5.internal.gzip.GZipFilter.service(GZipFilter.java:53)
> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
> at org.apache.tapestry5.internal.services.IgnoredPathsFilter.service(IgnoredPathsFilter.java:62)
> at $HttpServletRequestFilter_12eb55c012a.service($HttpServletRequestFilter_12eb55c012a.java)
> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
> at org.apache.tapestry5.services.TapestryModule$2.service(TapestryModule.java:928)
> at $HttpServletRequestHandler_12eb55c012e.service($HttpServletRequestHandler_12eb55c012e.java)
> at $HttpServletRequestHandler_12eb55c0128.service($HttpServletRequestHandler_12eb55c0128.java)
> at org.apache.tapestry5.TapestryFilter.doFilter(TapestryFilter.java:147)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:164)
> at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:141)
> at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:90)
> at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:417)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
> at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
> at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
> at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
> at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
> at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
> at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
> at java.lang.Thread.run(Thread.java:619)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org