You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/18 09:56:06 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #9230: Support get topic applied policy for InactiveTopic
315157973 opened a new pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230
Master Issue: #9216
### Modifications
1 Now if there is no data at the namespace-level, the broker-level data will be returned by default, so let it return null
2 add query param `applied` for getInactiveTopic
3 add `applied` API for client
### Verifying this change
unit test:
InactiveTopicDeleteTest#testInactiveTopicApplied
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762811168
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762811168
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762943150
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762946342
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762928758
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762946342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-763284808
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762763329
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762943150
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-763290646
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-763284808
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-763307882
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762964049
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762967528
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762544678
You have a style issue:
```
Error: src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:[874] (sizes) LineLength: Line is longer than 120 characters (found 121).
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (check-style) on project pulsar-broker: You have 1 Checkstyle violation. -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-763283713
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-763283713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762934066
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762763329
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762928758
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762972493
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762934066
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762965528
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 removed a comment on pull request #9230: Support get topic applied policy for InactiveTopic
Posted by GitBox <gi...@apache.org>.
315157973 removed a comment on pull request #9230:
URL: https://github.com/apache/pulsar/pull/9230#issuecomment-762967528
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org