You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/28 21:23:54 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4365:
Adding support for udf/expression in filter predicates
codecov-io edited a comment on issue #4365: Adding support for udf/expression in filter predicates
URL: https://github.com/apache/incubator-pinot/pull/4365#issuecomment-505682637
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=h1) Report
> Merging [#4365](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/b75a4c00169d68f9aabc87b01424664b73081ed3?src=pr&el=desc) will **increase** coverage by `21.7%`.
> The diff coverage is `69.44%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4365 +/- ##
============================================
+ Coverage 43.51% 65.22% +21.7%
- Complexity 0 20 +20
============================================
Files 1065 1066 +1
Lines 55228 55403 +175
Branches 7859 7894 +35
============================================
+ Hits 24032 36136 +12104
+ Misses 29133 16707 -12426
- Partials 2063 2560 +497
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/dociditerators/RangelessBitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9SYW5nZWxlc3NCaXRtYXBEb2NJZEl0ZXJhdG9yLmphdmE=) | `72.22% <ø> (+16.66%)` | `0 <0> (ø)` | :arrow_down: |
| [...che/pinot/core/operator/blocks/TransformBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvVHJhbnNmb3JtQmxvY2suamF2YQ==) | `71.42% <100%> (+2.19%)` | `0 <0> (ø)` | :arrow_down: |
| [...l/parsers/pql2/ast/ComparisonPredicateAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9Db21wYXJpc29uUHJlZGljYXRlQXN0Tm9kZS5qYXZh) | `43.9% <100%> (+23.41%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/startree/operator/StarTreeFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9vcGVyYXRvci9TdGFyVHJlZUZpbHRlck9wZXJhdG9yLmphdmE=) | `96.22% <100%> (+0.02%)` | `0 <0> (ø)` | :arrow_down: |
| [...r/filter/predicate/PredicateEvaluatorProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL1ByZWRpY2F0ZUV2YWx1YXRvclByb3ZpZGVyLmphdmE=) | `65.21% <100%> (-2.79%)` | `0 <0> (ø)` | |
| [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `87.21% <100%> (+35.33%)` | `0 <0> (ø)` | :arrow_down: |
| [...ava/org/apache/pinot/core/plan/FilterPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0ZpbHRlclBsYW5Ob2RlLmphdmE=) | `90.9% <100%> (+1.16%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/common/utils/request/FilterQueryTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9GaWx0ZXJRdWVyeVRyZWUuamF2YQ==) | `100% <100%> (+67.74%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/operator/dociditerators/SVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9TVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `67.85% <50%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/core/operator/filter/FilterOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRmlsdGVyT3BlcmF0b3JVdGlscy5qYXZh) | `87.87% <50%> (+9.75%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [576 more](https://codecov.io/gh/apache/incubator-pinot/pull/4365/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=footer). Last update [b75a4c0...aab63f2](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org