[GitHub] [cordova-plugin-splashscreen] bnfrnz edited a comment on issue #225: fix(android): Back button fix for SDK28

[GitBox <gi...@apache.org>]

bnfrnz edited a comment on issue #225: fix(android): Back button fix for SDK28
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/225#issuecomment-508940668
 
 
   @janpio, I've figured out why my app is still crashing. I am using another plugin ([NativePageTransitions](https://github.com/Telerik-Verified-Plugins/NativePageTransitions)) that also calls the function [View#setVisibility(int)](https://developer.android.com/reference/android/view/View.html#setVisibility(int)). So, I can confirm that running this function (on UI thread or not) is indeed causing the issue. 
   
   [This "fix"](https://github.com/apache/cordova-plugin-splashscreen/pull/225/files#diff-bb81295a5f916476389a7a0213be0498R101) basically just prevents the plugin from calling the function when running on API level 28  or higher. This isn't really a fix, right? I'm sure there was a point to calling that function...
   
   I've been trying to find out why on API level 28 it suddenly seems to be an issue to run `setVisibility` from a cordova activity, with no luck. I have zero experience with plugin/Android development. Maybe someone with experience could look into this and find out what should be used instead of `setVisibility` so we can replace it instead of simply deleting it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org