[GitHub] [hbase] Apache9 commented on a diff in pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r950839188


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -185,11 +175,6 @@ public static void sanityCheck(final Configuration c, final TableDescriptor td)
         warnOrThrowExceptionForFailure(logWarn, message, null);

Review Comment:
   This is the place where we use logWarn in this method? Then let's move the `boolean logWarn = !shouldSanityCheck(conf);` line here?



##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOpenRegionFailedMemoryLeak.java:
##########
@@ -60,6 +63,14 @@ public class TestOpenRegionFailedMemoryLeak {
 
   private static HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
 
+  @BeforeClass
+  public static void startCluster() throws Exception {
+    Configuration conf = TEST_UTIL.getConfiguration();
+
+    // Enable sanity check for coprocessor
+    conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true);

Review Comment:
   Why we need this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org