[GitHub] jihoonson closed pull request #6632: [Backport] remove backpressure time from DefaultQueryMetrics pending on-going discussion (#6631)

[GitBox <gi...@apache.org>]

jihoonson closed pull request #6632: [Backport] remove backpressure time from DefaultQueryMetrics pending on-going discussion (#6631)
URL: https://github.com/apache/incubator-druid/pull/6632
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
index b332fec98df..bedcffea099 100644
--- a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
+++ b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
@@ -246,7 +246,8 @@ public void identity(String identity)
   @Override
   public QueryMetrics<QueryType> reportBackPressureTime(long timeNs)
   {
-    return reportMillisTimeMetric("query/node/backpressure", timeNs);
+    // Don't emit by default.
+    return this;
   }
 
   @Override
diff --git a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
index 6f837d90248..72121b2bff6 100644
--- a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
+++ b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
@@ -152,10 +152,5 @@ public static void testQueryMetricsDefaultMetricNamesAndUnits(
     actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
     Assert.assertEquals("query/node/bytes", actualEvent.get("metric"));
     Assert.assertEquals(10L, actualEvent.get("value"));
-
-    queryMetrics.reportBackPressureTime(11000001).emit(serviceEmitter);
-    actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
-    Assert.assertEquals("query/node/backpressure", actualEvent.get("metric"));
-    Assert.assertEquals(11L, actualEvent.get("value"));
   }
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org