You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/25 12:59:37 UTC
[GitHub] [airflow] brunobastosg opened a new pull request #14457: Fixed deprecation message for "variables" command
brunobastosg opened a new pull request #14457:
URL: https://github.com/apache/airflow/pull/14457
closes: #13091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582963752
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
Old style:
`airflow variables -l`
New
`airflow variables list` etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582979227
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
Prepared PR https://github.com/apache/airflow/pull/14462 to supplement this, as mentioned above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582899755
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
This does not make sense to me:
```
root@99624d92186f:/opt/airflow# airflow variables
The 'variables' command is deprecated and removed in Airflow 2.0, please use 'variables list' instead
root@99624d92186f:/opt/airflow# airflow variables list
usage: airflow variables [-h] COMMAND ...
Manage variables
positional arguments:
COMMAND
delete Delete variable
export Export all variables
get Get variable
import Import variables
set Set variable
optional arguments:
-h, --help show this help message and exit
airflow variables command error: argument COMMAND: invalid choice: 'list' (choose from 'delete', 'export', 'get', 'import', 'set'), see help above.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #14457:
URL: https://github.com/apache/airflow/pull/14457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582957758
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
In such a case, we will also need to make further change to ensure `variables list` present in 1.10.x (say 1.10.15) as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#issuecomment-785877050
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582968411
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
I will shortly prepare a PR against branch v1-10-stable to add `airflow variables list` for `1.10.15`.
Meanwhile, I think this PR is ok to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#issuecomment-786415291
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582954207
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
Hi @kaxil , that's because `variables list` is missed in the new Variable Commands in 1.10.14 (https://github.com/apache/airflow/blob/1.10.14/airflow/bin/cli.py#L3066), but it is a valid new command in 2.0 (https://github.com/apache/airflow/blob/2.0.1/airflow/cli/cli_parser.py#L1037)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582968411
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
I will shortly prepare a PR against branch v1-10-stable to add `airflow variables list`.
Meanwhile, I think this PR is ok to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#discussion_r582994664
##########
File path: airflow/bin/cli.py
##########
@@ -414,7 +414,7 @@ def variables_export(args):
_vars_wrapper(args, export=args.file)
-@cli_utils.deprecated_action(new_name='variables')
+@cli_utils.deprecated_action(new_name='variables list')
Review comment:
Cool, approved #14462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14457: Fixed deprecation message for "variables" command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14457:
URL: https://github.com/apache/airflow/pull/14457#issuecomment-785983790
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org