You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/19 19:28:44 UTC

[GitHub] [cordova-plugin-camera] riddletd opened a new pull request #527: GH-506 ios: This should fix the issue based on litiobat comment.

riddletd opened a new pull request #527: GH-506 ios: This should fix the issue based on litiobat comment.
URL: https://github.com/apache/cordova-plugin-camera/pull/527
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   [#506](https://github.com/apache/cordova-plugin-camera/issues/506)
   
   ### Description
   <!-- Describe your changes in detail -->
   
   I updated resultForVideo() with the solution provided in issue #506 by litiobat.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   I have tested this code on iPhone 7 Plus with iOS 13.1.3 as well as multiple iPhone simulations using iOS 13.
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org