You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/11/28 14:07:09 UTC
Review Request 54125: Abillity to enable SPNEGO on Log Search Portal
UI from Ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-18996
https://issues.apache.org/jira/browse/AMBARI-18996
Repository: ambari
Description
-------
add spnego authentication related properties to the logsearch stack.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
ambari-web/app/data/HDP2/site_properties.js d61d4aa
Diff: https://reviews.apache.org/r/54125/diff/
Testing
-------
testing done.
Thanks,
Oliver Szabo
Re: Review Request 54125: Abillity to enable SPNEGO on Log Search
Portal UI from Ambari
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 12:49 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
change enable constant to enabled
Bugs: AMBARI-18996
https://issues.apache.org/jira/browse/AMBARI-18996
Repository: ambari
Description
-------
add spnego authentication related properties to the logsearch stack.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
ambari-web/app/data/HDP2/site_properties.js d61d4aa
Diff: https://reviews.apache.org/r/54125/diff/
Testing
-------
testing done. (python):
Total run:1163
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:26.421s
[INFO] Finished at: Mon Nov 28 15:38:32 CET 2016
[INFO] Final Memory: 63M/1180M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 54125: Abillity to enable SPNEGO on Log Search
Portal UI from Ambari
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/#review157234
-----------------------------------------------------------
Fix it, then Ship it!
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java (line 75)
<https://reviews.apache.org/r/54125/#comment227768>
You should consider to rename the variable to KERBEROS_ENABLED for consistency reasons.
- Miklos Gergely
On Nov. 28, 2016, 4:04 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54125/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 4:04 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-18996
> https://issues.apache.org/jira/browse/AMBARI-18996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add spnego authentication related properties to the logsearch stack.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
> ambari-web/app/data/HDP2/site_properties.js d61d4aa
>
> Diff: https://reviews.apache.org/r/54125/diff/
>
>
> Testing
> -------
>
> testing done. (python):
>
> Total run:1163
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:26.421s
> [INFO] Finished at: Mon Nov 28 15:38:32 CET 2016
> [INFO] Final Memory: 63M/1180M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 54125: Abillity to enable SPNEGO on Log Search
Portal UI from Ambari
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/
-----------------------------------------------------------
(Updated Nov. 28, 2016, 4:04 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
fixed typos
Bugs: AMBARI-18996
https://issues.apache.org/jira/browse/AMBARI-18996
Repository: ambari
Description
-------
add spnego authentication related properties to the logsearch stack.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
ambari-web/app/data/HDP2/site_properties.js d61d4aa
Diff: https://reviews.apache.org/r/54125/diff/
Testing
-------
testing done. (python):
Total run:1163
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:26.421s
[INFO] Finished at: Mon Nov 28 15:38:32 CET 2016
[INFO] Final Memory: 63M/1180M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 54125: Abillity to enable SPNEGO on Log Search
Portal UI from Ambari
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/#review157038
-----------------------------------------------------------
Fix it, then Ship it!
The patch looks fine to me overall. Just a few minor issues (spelling typos) that need to be fixed first.
Thanks.
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml (line 243)
<https://reviews.apache.org/r/54125/#comment227420>
Minor issue:
Just a type, "Enalbe" should be "Enable"
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml (line 253)
<https://reviews.apache.org/r/54125/#comment227422>
Minor issue:
Typo in "authetication", should be "authentication"
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml (line 263)
<https://reviews.apache.org/r/54125/#comment227423>
Minor issue:
Same typo for "authentication"
- Robert Nettleton
On Nov. 28, 2016, 2:41 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54125/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 2:41 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-18996
> https://issues.apache.org/jira/browse/AMBARI-18996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add spnego authentication related properties to the logsearch stack.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
> ambari-web/app/data/HDP2/site_properties.js d61d4aa
>
> Diff: https://reviews.apache.org/r/54125/diff/
>
>
> Testing
> -------
>
> testing done. (python):
>
> Total run:1163
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:26.421s
> [INFO] Finished at: Mon Nov 28 15:38:32 CET 2016
> [INFO] Final Memory: 63M/1180M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 54125: Abillity to enable SPNEGO on Log Search
Portal UI from Ambari
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/
-----------------------------------------------------------
(Updated Nov. 28, 2016, 2:41 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
added test passed messages to the build success output
Bugs: AMBARI-18996
https://issues.apache.org/jira/browse/AMBARI-18996
Repository: ambari
Description
-------
add spnego authentication related properties to the logsearch stack.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
ambari-web/app/data/HDP2/site_properties.js d61d4aa
Diff: https://reviews.apache.org/r/54125/diff/
Testing (updated)
-------
testing done. (python):
Total run:1163
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:26.421s
[INFO] Finished at: Mon Nov 28 15:38:32 CET 2016
[INFO] Final Memory: 63M/1180M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 54125: Abillity to enable SPNEGO on Log Search
Portal UI from Ambari
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54125/
-----------------------------------------------------------
(Updated Nov. 28, 2016, 2:36 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-18996
https://issues.apache.org/jira/browse/AMBARI-18996
Repository: ambari
Description
-------
add spnego authentication related properties to the logsearch stack.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java 808320d
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 7641b0c
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml 9dcd5cf
ambari-web/app/data/HDP2/site_properties.js d61d4aa
Diff: https://reviews.apache.org/r/54125/diff/
Testing (updated)
-------
testing done. (python):
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50.665s
[INFO] Finished at: Mon Nov 28 14:55:43 CET 2016
[INFO] Final Memory: 66M/1181M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo