[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #800: kubernetesservicetab: Selecting the right ip

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #800:
URL: https://github.com/apache/cloudstack-primate/pull/800#discussion_r503121949



##########
File path: src/views/compute/KubernetesServiceTab.vue
##########
@@ -327,14 +327,14 @@ export default {
           this.resource.projectid !== '') {
           params.projectid = this.resource.projectid
         }
-        if (this.isValidValueForKey(this.resource, 'associatednetworkid')) {
-          params.associatednetworkid = this.resource.associatednetworkid
+        if (this.isValidValueForKey(this.resource, 'networkid')) {
+          params.associatednetworkid = this.resource.networkid
         }
       }
       api('listPublicIpAddresses', params).then(json => {
         const ips = json.listpublicipaddressesresponse.publicipaddress
         if (this.arrayHasItems(ips)) {
-          this.publicIpAddress = ips[0]
+          this.publicIpAddress = ips.filter(x => x.issourcenat)[0]

Review comment:
       Does this break on shared networks, are shared networks supported for CKS @shwstppr? What about VPCs? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org