You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2021/01/15 06:05:00 UTC

[jira] [Resolved] (HBASE-25431) MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

     [ https://issues.apache.org/jira/browse/HBASE-25431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stack resolved HBASE-25431.
-----------------------------------
    Fix Version/s: 2.5.0
                   3.0.0-alpha-1
     Hadoop Flags: Reviewed
       Resolution: Fixed

Nice contrib. Thanks [~DeanZ]. Shout if you want it to go back further than branch-2 (Going easy on the backports because branch-2.4 and branch-2.3 are trying to push out releases).

> MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number
> ---------------------------------------------------------------------
>
>                 Key: HBASE-25431
>                 URL: https://issues.apache.org/jira/browse/HBASE-25431
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha-1, 2.4.0
>            Reporter: Baiqiang Zhao
>            Assignee: Baiqiang Zhao
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>         Attachments: image-2020-12-22-11-46-38-967.png
>
>
> Before create or alter table, we will do sanityCheck in TableDescriptorChecker. If MAX_FILESIZE or MEMSTORE_FLUSHSIZE < 0, use maxFileSizeLowerLimit or flushSizeLowerLimit instead to pass check. But the real value in TableDescriptor is still < 0, and we can see negative values on the UI.
> However in flush and split logic, MAX_FILESIZE and MEMSTORE_FLUSHSIZE will judge whether it's value <= 0 , if true, change to default value. This does not affect flush and split.
> !image-2020-12-22-11-46-38-967.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)