You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org> on 2019/01/08 06:47:00 UTC
[jira] [Commented] (FLINK-11280)
RocksDBSerializedCompositeKeyBuilder's key serializer is not being
reconfigured properly
[ https://issues.apache.org/jira/browse/FLINK-11280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736804#comment-16736804 ]
Tzu-Li (Gordon) Tai commented on FLINK-11280:
---------------------------------------------
I think the same goes for some of our other state handle classes, e.g. {{RocksDBListState}} which holds its own copy of the list's element serializer. Will need to double check them.
> RocksDBSerializedCompositeKeyBuilder's key serializer is not being reconfigured properly
> ----------------------------------------------------------------------------------------
>
> Key: FLINK-11280
> URL: https://issues.apache.org/jira/browse/FLINK-11280
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Critical
>
> This can be confirmed by failing tests:
> [https://travis-ci.org/apache/flink/jobs/476533588]
> The failing test is {{StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfiguration}}, which was a new test added in FLINK-11073.
> This test started to fail when the changes were rebased on top of FLINK-9702.
> The problem is that starting from FLINK-11073, all state serializers (including key serializer) should be wrapped within / retrieved from a {{StateSerializerProvider}}, which handles the logic of compatibility checks of state serializers and reassigning serializer references to reconfigured instances if required.
> The new {{RocksDBSerializedCompositeKeyBuilder}} introduced in FLINK-9702, however, holds its own final reference directly to the key serializer, instead of using a {{StateSerializerProvider}}.
> This change essentially makes the key serializer non-reconfigurable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)