You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/27 10:32:55 UTC
[GitHub] [kafka] dgd-contributor opened a new pull request #10774: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is
dgd-contributor opened a new pull request #10774:
URL: https://github.com/apache/kafka/pull/10774
The Worker class has an executor field that the public constructor initializes with a new cached thread pool (https://github.com/apache/kafka/blob/02226fa090513882b9229ac834fd493d71ae6d96/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L127.]).
When the worker is stopped, it does not shutdown this executor. This is normally okay in the Connect runtime and MirrorMaker 2 runtimes, because the worker is stopped only when the JVM is stopped (via the shutdown hook in the herders).
However, we instantiate and stop the herder many times in our integration tests, and this means we're not necessarily shutting down the herder's executor. Normally this won't hurt, as long as all of the runnables that the executor threads run actually do terminate. But it's possible those threads might not terminate in all tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dgd-contributor closed pull request #10774: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is
Posted by GitBox <gi...@apache.org>.
dgd-contributor closed pull request #10774:
URL: https://github.com/apache/kafka/pull/10774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dgd-contributor commented on pull request #10774: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is
Posted by GitBox <gi...@apache.org>.
dgd-contributor commented on pull request #10774:
URL: https://github.com/apache/kafka/pull/10774#issuecomment-850130305
cc @showuon , PTAK, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org