You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/30 20:53:55 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6735: NIFI-10899 Add SameSite Policy to Application Cookies
exceptionfactory opened a new pull request, #6735:
URL: https://github.com/apache/nifi/pull/6735
- Added __Secure prefix to Application Cookie Names
# Summary
[NIFI-10899](https://issues.apache.org/jira/browse/NIFI-10899) Adds the `SameSite` attribute to all application cookies. The current security configuration applies `SameSite=Strict` to the `__Secure-Authorization-Bearer` Cookie, but no other cookies have the `SameSite` policy applied.
The changes implemented add a `SameSitePolicy` enumeration and update the `ApplicationCookieName` enumeration to indicate the policy that will be applied. The implementation applies a `SameSite` attribute to all application cookies to avoid browser warnings and fallback to implicit behavior.
The `__Secure-Authorization-Bearer` and `__Secure-Request-Token` cookies are limited to first-party access, so both of those cookies have the `Strict` policy configured.
The Logout, SAML, and OIDC cookies require a value of `None` for the `SameSite` attribute because authentication and logout involves redirects between NiFi and external identity providers.
Additional changes include adding the `__Secure` [prefix](https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#cookie_prefixes) to the the Logout, SAML, and OIDC cookie names .
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [X] JDK 11
- [X] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6735:
URL: https://github.com/apache/nifi/pull/6735#issuecomment-1337993707
Confirmed that the OIDC cookie names were updated with the SameSite=none attribute applied. +1 will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog closed pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies
Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies
URL: https://github.com/apache/nifi/pull/6735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6735: NIFI-10899 Add SameSite Policy to Application Cookies
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6735:
URL: https://github.com/apache/nifi/pull/6735#issuecomment-1337669138
Will review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org