[jira] [Work logged] (HIVE-26064) For Iceberg external table do not set external.table.purge=true by default

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-26064?focusedWorklogId=746615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746615 ]

ASF GitHub Bot logged work on HIVE-26064:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Mar/22 14:30
            Start Date: 23/Mar/22 14:30
    Worklog Time Spent: 10m 
      Work Description: pvary opened a new pull request #3132:
URL: https://github.com/apache/hive/pull/3132


   ### What changes were proposed in this pull request?
   HiveIcebergMetaHook should not set `external.table.purge`. We should leave that decision for the user.
   
   ### Why are the changes needed?
   With the current solution the table data is removed for external tables which is not expected by the customers.
   
   ### Does this PR introduce _any_ user-facing change?
   By default the `external.table.purge` is not set
   
   ### How was this patch tested?
   Added unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 746615)
    Remaining Estimate: 0h
            Time Spent: 10m

> For Iceberg external table do not set external.table.purge=true by default
> --------------------------------------------------------------------------
>
>                 Key: HIVE-26064
>                 URL: https://issues.apache.org/jira/browse/HIVE-26064
>             Project: Hive
>          Issue Type: Task
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When creating an Iceberg table, in the MetaHook we currently set external.table.purge=true for all tables, unless provided otherwise.
> This goes against the docs / user expectations: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=82706445#:~:text=When%20dropping%20an%20EXTERNAL%20table%2C%20data%20in%20the%20table%20is%20NOT%20deleted%20from%20the%20file%20system
> As well as this property: hive.external.table.purge.default, which is set to false in the system.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)