You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/14 14:37:30 UTC
[GitHub] [solr-operator] gerlowskija opened a new pull request #394: Make GcsRepository.gcsCredentialSecret optional
gerlowskija opened a new pull request #394:
URL: https://github.com/apache/solr-operator/pull/394
There are some circumstances where GCS access can be managed without
explicitly providing a service account key (e.g. when GKE's "Workload
Identity" feature is used to provide auth metadata).
This commit drops the hard requirement on the `gcsCredentialSecret`
property with this in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija merged pull request #394: Make GcsRepository.gcsCredentialSecret optional
Posted by GitBox <gi...@apache.org>.
gerlowskija merged pull request #394:
URL: https://github.com/apache/solr-operator/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija merged pull request #394: Make GcsRepository.gcsCredentialSecret optional
Posted by GitBox <gi...@apache.org>.
gerlowskija merged pull request #394:
URL: https://github.com/apache/solr-operator/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #394: Make GcsRepository.gcsCredentialSecret optional
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #394:
URL: https://github.com/apache/solr-operator/pull/394#issuecomment-1020233518
We could go ahead and upgrade to golang 1.17 as well (though it should be a separate ticket). I was waiting for 1.18, but it will probably be a while until that is good to use in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on pull request #394: Make GcsRepository.gcsCredentialSecret optional
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on pull request #394:
URL: https://github.com/apache/solr-operator/pull/394#issuecomment-1020230843
Hmm, looks like I've got `go version go1.17.5 darwin/amd64` locally.
Thanks for the review and the heads up on the build failure - it's been on my list but I hadn't circled back yet. Gonna address those review comments now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org