You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2011/07/05 15:16:16 UTC

[jira] [Created] (WICKET-3871) ResourceStreamRequestHandler should use content-disposition attachment when filename is set

ResourceStreamRequestHandler should use content-disposition attachment when filename is set
-------------------------------------------------------------------------------------------

                 Key: WICKET-3871
                 URL: https://issues.apache.org/jira/browse/WICKET-3871
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.5-RC5.1
            Reporter: Martijn Dashorst
             Fix For: 1.5-RC6


The ResourceStreamRequestHandler sets the filename and documents its use as "sets the content-disposition header". By default the content disposition type is "inline". The combination of setting the filename with type inline is not very useful.

With IE on XP this will result in strange errors where documents are viewed as zip files, etc, but also with "normal" browsers, this will result in the downloaded file to be rendered in the browser window. Wicket 1.4 provided the filename with content disposition "attached".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WICKET-3871) ResourceStreamRequestHandler should use content-disposition attachment when filename is set

Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn Dashorst resolved WICKET-3871.
--------------------------------------

    Resolution: Fixed
      Assignee: Martijn Dashorst

Fixed by checking if the contentdisposition was set, and if not, determine the disposition by checking if the filename was set (in that case use attachment, else use inline)

> ResourceStreamRequestHandler should use content-disposition attachment when filename is set
> -------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3871
>                 URL: https://issues.apache.org/jira/browse/WICKET-3871
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC5.1
>            Reporter: Martijn Dashorst
>            Assignee: Martijn Dashorst
>             Fix For: 1.5-RC6
>
>
> The ResourceStreamRequestHandler sets the filename and documents its use as "sets the content-disposition header". By default the content disposition type is "inline". The combination of setting the filename with type inline is not very useful.
> With IE on XP this will result in strange errors where documents are viewed as zip files, etc, but also with "normal" browsers, this will result in the downloaded file to be rendered in the browser window. Wicket 1.4 provided the filename with content disposition "attached".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira